You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/05 17:37:00 UTC

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #3063: ARTEMIS-2692 refactor queue creation

michaelandrepearce edited a comment on issue #3063: ARTEMIS-2692 refactor queue creation
URL: https://github.com/apache/activemq-artemis/pull/3063#issuecomment-609453531
 
 
   Could i suggest this PR is split in two. One with the refactor where tests remain untouched. And the once that is merged and a full build with all tests run not just the pr ones. Then a subsequent pr is raised to update tests. 
   
   Reason for this is that this is a sizeable refactor and even human eye looking over may miss something. Where as we do expect if refactor all historic tests should pass without modification. By having both refactor and tests change at the same time its hard to get confidence theres no regressions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services