You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by andreschembri <gi...@git.apache.org> on 2015/04/09 11:55:18 UTC
[GitHub] incubator-brooklyn pull request: added representation of registere...
GitHub user andreschembri opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/588
added representation of registeredType to CatalogItemSummary
added String registeredType; since rest client was failing because it could not represent the JSON returned correctly .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andreschembri/incubator-brooklyn catalogitemsummaryfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/588.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #588
----
commit 5512dae60c5cf9bc5c1c855e0074d6e4406ca956
Author: Andre <an...@andres-macbook-pro.local>
Date: 2015-04-09T09:51:32Z
added representation of registeredType to CatalogItemSummary
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: added representation of registere...
Posted by andreschembri <gi...@git.apache.org>.
Github user andreschembri closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: added representation of registere...
Posted by andreschembri <gi...@git.apache.org>.
Github user andreschembri commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/588#issuecomment-91251905
it seems that there are calls that use this class that do not yet provide the registeredType property, hence my modification was breaking the code. I am going to change this and reopen a different pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: added representation of registere...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/588#issuecomment-91352587
@andreschembri does #585 address this sufficiently? it's not the main focus of that PR but it adds the annotation `@JsonIgnoreProperties(ignoreUnknown = true)` which should stop errors
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---