[jira] [Commented] (HDFS-17613) Logging Enhancement for Invalid Metrics Logger Period in DataNode

["LoggingResearch (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879408#comment-17879408 ] 

LoggingResearch commented on HDFS-17613:
----------------------------------------

To make it clear on how to fix the issue, we upload the comparison between the original version and the log-enhanced version in the attached file `original-vs-log-enhanced.md`.  The log-enhanced version is generated automatically utilizing our proposed tool. 

> Logging Enhancement for Invalid Metrics Logger Period in DataNode
> -----------------------------------------------------------------
>
>                 Key: HDFS-17613
>                 URL: https://issues.apache.org/jira/browse/HDFS-17613
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.3.6
>         Environment: Version: {{`3.3.6`}}
> Location: {{`hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java`}} , in {{`startMetricsLogger`}} method, lines 4192-4194
>            Reporter: LoggingResearch
>            Priority: Major
>         Attachments: TestDatanodeRegister.java, original-vs-log-enhanced.md
>
>
> This case involves the enhancement of the {{startMetricsLogger}} method in {{DataNode.java}} to log a warning message when the {{dfs.datanode.metrics.logger.period.seconds}} configuration parameter is set to a non-positive value. The original implementation silently ignored non-positive values, which could lead to confusion for the operators.
>  
> *Expected Behavior:* 
> The system should log a clear warning when the metrics logger period is set to a non-positive value, indicating that the logger will not start. This provides better visibility and aids in troubleshooting configuration issues.
>  
> *How-to-Fix:* The method {{startMetricsLogger}} should be enhanced to log a warning when the metrics logger period is set to a non-positive value. This can be achieved by inserting a logger statement before returning from the method if the period is invalid.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org