[GitHub] [solr] alessandrobenedetti commented on pull request #1260: SOLR-788: transfer mlt query for component right

["alessandrobenedetti (via GitHub)" <gi...@apache.org>]

alessandrobenedetti commented on PR #1260:
URL: https://github.com/apache/solr/pull/1260#issuecomment-1438816549

   You are welcome! I saw you changed the anonymous 'id' to 'docNum'.
   It's probably fine, but it didn't look intuitive to me as a name so I checked in the Solr code base, and it seems 'docId' to be more present and widespread used?
   You know it's a super minor thing, I have a soft preference for using 'docId' but up to you!
   And thanks for the nice work and refactoring, the MoreLikeThis needed some love, I really appreciate it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org