You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/20 16:15:31 UTC
[GitHub] [spark] huaxingao opened a new pull request #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
huaxingao opened a new pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972
### What changes were proposed in this pull request?
add instr.logSumOfWeights in the Algo that has weightCol support
### Why are the changes needed?
Many algorithms support weightCol now. I think weightsum is useful info to add to the log.
### Does this PR introduce any user-facing change?
no
### How was this patch tested?
manually tested
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569865013
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20774/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568587302
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569528995
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-567991469
**[Test build #115629 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115629/testReport)** for PR 26972 at commit [`e86a2d3`](https://github.com/apache/spark/commit/e86a2d38ef3d94dd39b778ecf622697ab2a3fc83).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568021693
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r360658499
##########
File path: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
##########
@@ -126,6 +126,8 @@ class DecisionTreeClassifier @Since("1.4.0") (
}
validateNumClasses(numClasses)
val instances = extractInstances(dataset, numClasses)
+ val weightSum = instances.map(_.weight).reduce(_ + _)
Review comment:
Hm, on second thought, this requires an extra pass to compute the weights. Is it worth it? is there any other place to get this info instead without adding a Spark job?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568587307
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115652/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569528882
**[Test build #115920 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115920/testReport)** for PR 26972 at commit [`9d3821e`](https://github.com/apache/spark/commit/9d3821ebcd9c41069c9091f364c9bfbba1693b29).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568576394
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569523565
**[Test build #115920 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115920/testReport)** for PR 26972 at commit [`9d3821e`](https://github.com/apache/spark/commit/9d3821ebcd9c41069c9091f364c9bfbba1693b29).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522786
**[Test build #115919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115919/testReport)** for PR 26972 at commit [`92754ba`](https://github.com/apache/spark/commit/92754bae81a4cddb458d2a6ef4601df62031f3a1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569732648
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20758/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522968
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115919/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522195
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20709/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r361961374
##########
File path: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
##########
@@ -261,7 +264,8 @@ private[spark] object GradientBoostedTrees extends Logging {
boostingStrategy: OldBoostingStrategy,
validate: Boolean,
seed: Long,
- featureSubsetStrategy: String): (Array[DecisionTreeRegressionModel], Array[Double]) = {
+ featureSubsetStrategy: String,
+ instr: Option[Instrumentation]): (Array[DecisionTreeRegressionModel], Array[Double]) = {
Review comment:
nit: I suggest to add a default value `instr: Option[Instrumentation] = None`,
so that changes in mllib/tree/GradientBoostedTrees.scala and ml/tree/impl/GradientBoostedTreesSuite.scala can be avoided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522193
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-567991469
**[Test build #115629 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115629/testReport)** for PR 26972 at commit [`e86a2d3`](https://github.com/apache/spark/commit/e86a2d38ef3d94dd39b778ecf622697ab2a3fc83).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568520956
cc @zhengruifeng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][ML] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569732219
**[Test build #115965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115965/testReport)** for PR 26972 at commit [`7120e19`](https://github.com/apache/spark/commit/7120e195266ea9e94351a48a29f0205b72a7344a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569875692
Merged to master, thanks all!
Happy new year!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568003206
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r361865083
##########
File path: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala
##########
@@ -204,9 +204,10 @@ class GBTClassifier @Since("1.4.0") (
val boostingStrategy = super.getOldBoostingStrategy(categoricalFeatures, OldAlgo.Classification)
val (baseLearners, learnerWeights) = if (withValidation) {
GradientBoostedTrees.runWithValidation(trainDataset, validationDataset, boostingStrategy,
- $(seed), $(featureSubsetStrategy))
+ $(seed), $(featureSubsetStrategy), Some(instr))
Review comment:
OK, it's slightly messy to pass the instrumentation object here, but I think none of the changes here require new computation. I'm OK with it if you think it's important to log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568021705
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115629/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569732635
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522967
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569749583
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115965/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568610797
I notice that other statistics for tree models are logged in `RandomForest.run`:
```scala
instr match {
case Some(instrumentation) =>
instrumentation.logNumFeatures(metadata.numFeatures)
instrumentation.logNumClasses(metadata.numClasses)
instrumentation.logNumExamples(metadata.numExamples)
case None =>
logInfo("numFeatures: " + metadata.numFeatures)
logInfo("numClasses: " + metadata.numClasses)
logInfo("numExamples: " + metadata.numExamples)
}
```
Can we just log `weightSum` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568012514
**[Test build #4972 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4972/testReport)** for PR 26972 at commit [`e86a2d3`](https://github.com/apache/spark/commit/e86a2d38ef3d94dd39b778ecf622697ab2a3fc83).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522212
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115918/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569871434
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522964
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522786
**[Test build #115919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115919/testReport)** for PR 26972 at commit [`92754ba`](https://github.com/apache/spark/commit/92754bae81a4cddb458d2a6ef4601df62031f3a1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r361028836
##########
File path: mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala
##########
@@ -56,6 +56,8 @@ private[spark] trait DecisionTreeModel {
rootNode.subtreeDepth
}
+ var weightSum: Double
Review comment:
Where is this and above var `weightSum` computed or setted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522193
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569528997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115920/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569871438
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115982/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568003206
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569749583
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115965/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522967
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569865008
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568576397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20451/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569732648
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20758/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522084
**[Test build #115918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115918/testReport)** for PR 26972 at commit [`6f9a9c8`](https://github.com/apache/spark/commit/6f9a9c8758b970563fab723233005611b0b42beb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r361028836
##########
File path: mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala
##########
@@ -56,6 +56,8 @@ private[spark] trait DecisionTreeModel {
rootNode.subtreeDepth
}
+ var weightSum: Double
Review comment:
Where are this and above var `weightSum` in tree models computed or setted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522964
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522084
**[Test build #115918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115918/testReport)** for PR 26972 at commit [`6f9a9c8`](https://github.com/apache/spark/commit/6f9a9c8758b970563fab723233005611b0b42beb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568587302
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r361028836
##########
File path: mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala
##########
@@ -56,6 +56,8 @@ private[spark] trait DecisionTreeModel {
rootNode.subtreeDepth
}
+ var weightSum: Double
Review comment:
Where are this and above var `weightSum` in tree models computed or setted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522966
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20710/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568575582
**[Test build #115652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115652/testReport)** for PR 26972 at commit [`93cf0be`](https://github.com/apache/spark/commit/93cf0bef33a057ec848da28d514f327fba136080).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r362042204
##########
File path: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala
##########
@@ -204,9 +204,10 @@ class GBTClassifier @Since("1.4.0") (
val boostingStrategy = super.getOldBoostingStrategy(categoricalFeatures, OldAlgo.Classification)
val (baseLearners, learnerWeights) = if (withValidation) {
GradientBoostedTrees.runWithValidation(trainDataset, validationDataset, boostingStrategy,
- $(seed), $(featureSubsetStrategy))
+ $(seed), $(featureSubsetStrategy), Some(instr))
Review comment:
I hope it's slightly better now after I added the default value ```instr: Option[Instrumentation] = None```. The code here is still the same, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][ML] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569749362
**[Test build #115965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115965/testReport)** for PR 26972 at commit [`7120e19`](https://github.com/apache/spark/commit/7120e195266ea9e94351a48a29f0205b72a7344a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568624801
We can log ```weightSum``` in ```RandomForest.run```, but for ```GBTClassifier``` and ```GBTRegresor```, I think this is logged for each iteration, so it's logged multiple times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r360688350
##########
File path: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
##########
@@ -126,6 +126,8 @@ class DecisionTreeClassifier @Since("1.4.0") (
}
validateNumClasses(numClasses)
val instances = extractInstances(dataset, numClasses)
+ val weightSum = instances.map(_.weight).reduce(_ + _)
Review comment:
I will take a look to find out if ```weightSum``` is already available in other place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568576397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20451/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569523675
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569865013
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20774/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522965
**[Test build #115919 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115919/testReport)** for PR 26972 at commit [`92754ba`](https://github.com/apache/spark/commit/92754bae81a4cddb458d2a6ef4601df62031f3a1).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522212
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115918/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522968
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115919/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569523565
**[Test build #115920 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115920/testReport)** for PR 26972 at commit [`9d3821e`](https://github.com/apache/spark/commit/9d3821ebcd9c41069c9091f364c9bfbba1693b29).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569528997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115920/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569749577
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-567983127
**[Test build #4972 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4972/testReport)** for PR 26972 at commit [`e86a2d3`](https://github.com/apache/spark/commit/e86a2d38ef3d94dd39b778ecf622697ab2a3fc83).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568021705
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115629/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568003494
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20429/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][ML] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569871313
**[Test build #115982 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115982/testReport)** for PR 26972 at commit [`7120e19`](https://github.com/apache/spark/commit/7120e195266ea9e94351a48a29f0205b72a7344a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522210
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568575582
**[Test build #115652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115652/testReport)** for PR 26972 at commit [`93cf0be`](https://github.com/apache/spark/commit/93cf0bef33a057ec848da28d514f327fba136080).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][ML] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569864866
**[Test build #115982 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115982/testReport)** for PR 26972 at commit [`7120e19`](https://github.com/apache/spark/commit/7120e195266ea9e94351a48a29f0205b72a7344a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569523676
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20711/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569523675
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569732635
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522195
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20709/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522210
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569871438
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115982/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569871434
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568587307
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115652/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r362037331
##########
File path: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
##########
@@ -261,7 +264,8 @@ private[spark] object GradientBoostedTrees extends Logging {
boostingStrategy: OldBoostingStrategy,
validate: Boolean,
seed: Long,
- featureSubsetStrategy: String): (Array[DecisionTreeRegressionModel], Array[Double]) = {
+ featureSubsetStrategy: String,
+ instr: Option[Instrumentation]): (Array[DecisionTreeRegressionModel], Array[Double]) = {
Review comment:
Good point. I will update the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568991530
@huaxingao Can we pass the instr of GBTClassifier/GBTRegressor into the internal impl, and use it to log the metrics in the first tree building?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522207
**[Test build #115918 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115918/testReport)** for PR 26972 at commit [`6f9a9c8`](https://github.com/apache/spark/commit/6f9a9c8758b970563fab723233005611b0b42beb).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569865008
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569749577
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568021340
**[Test build #115629 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115629/testReport)** for PR 26972 at commit [`e86a2d3`](https://github.com/apache/spark/commit/e86a2d38ef3d94dd39b778ecf622697ab2a3fc83).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569528995
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569864866
**[Test build #115982 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115982/testReport)** for PR 26972 at commit [`7120e19`](https://github.com/apache/spark/commit/7120e195266ea9e94351a48a29f0205b72a7344a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26972: [SPARK-30321][Ml] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568587106
**[Test build #115652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115652/testReport)** for PR 26972 at commit [`93cf0be`](https://github.com/apache/spark/commit/93cf0bef33a057ec848da28d514f327fba136080).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26972:
[SPARK-30321][ML] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569732219
**[Test build #115965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115965/testReport)** for PR 26972 at commit [`7120e19`](https://github.com/apache/spark/commit/7120e195266ea9e94351a48a29f0205b72a7344a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568576394
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568021693
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #26972: [SPARK-30321][ML] Log
weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-570005163
Thank you for your help! Wish you all a very Happy New Year!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568828877
Yes, current GBT impls will log these metrics for each iteration. But I guess we can just log weightSum there, if there is not an easy way to log all of them only once (at iteration 0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569523676
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20711/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-567983127
**[Test build #4972 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4972/testReport)** for PR 26972 at commit [`e86a2d3`](https://github.com/apache/spark/commit/e86a2d38ef3d94dd39b778ecf622697ab2a3fc83).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26972: [SPARK-30321][Ml]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568003494
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20429/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26972:
[SPARK-30321][Ml] Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569522966
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20710/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][ML]
Log weightSum in Algo that has weights support
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-569864240
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org