You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Venkata Guddanti (JIRA)" <ad...@incubator.apache.org> on 2006/08/11 01:24:14 UTC
[jira] Updated: (ADFFACES-120) Bugs in the MultiPartFormHandler
[ http://issues.apache.org/jira/browse/ADFFACES-120?page=all ]
Venkata Guddanti updated ADFFACES-120:
--------------------------------------
Status: Patch Available (was: Open)
> Bugs in the MultiPartFormHandler
> --------------------------------
>
> Key: ADFFACES-120
> URL: http://issues.apache.org/jira/browse/ADFFACES-120
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Venkata Guddanti
> Attachments: MultipartFormHandler.java, trunk.patch
>
>
> There are couple of bugs in the MultiPartFormHandler because of which it is loosing a byte during the upload process. The two bugs are:
> 1. The MultiPartFormHandler$MultipartFormItem$MultipartInputStream wraps the ServletInputStream and maintains its own buffer. For every read request fills up the buffer by doing multiple reads on the ServletInputStream and serves the data from its buffer during a read operation. There was some bug in the complex buffering logic where it was dropping a byte. The fix is to not to fill up the buffer from the ServletInputStream and instead go to the ServletInputStream.readLine whenever necessary for every read operation. Similar fix needs to be applied in the MultiPartFormHandler$MultipartFormItem.writeFile logic since it is doing the same logic
> 2. There was a bug in the _readLine logic of MultiPartFormHandler. It was dropping a byte under certain rare circumstances where the internal buffer was getting full and when the last character read was a CR.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira