You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/13 07:47:15 UTC

[GitHub] [dubbo] AlbumenJ commented on a change in pull request #9015: [3.0] change getRegistries return type to HashSet for unique, create different zkClient for different application

AlbumenJ commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r727789664



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java
##########
@@ -906,19 +907,6 @@ private void destroyProtocols() {
         }
     }
 
-    private void destroyServiceDiscoveries() {
-        RegistryManager.getInstance(applicationModel).getServiceDiscoveries().forEach(serviceDiscovery -> {
-            try {
-                serviceDiscovery.destroy();
-            } catch (Throwable ignored) {
-                logger.warn(ignored.getMessage(), ignored);
-            }
-        });
-        if (logger.isDebugEnabled()) {
-            logger.debug(getIdentifier() + "'s all ServiceDiscoveries have been destroyed.");
-        }
-    }
-

Review comment:
       cloud you pls desc why you remove these code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org