You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/01 08:15:40 UTC

[GitHub] [arrow-datafusion] waynexia opened a new pull request, #3323: MINOR: add github action trigger

waynexia opened a new pull request, #3323:
URL: https://github.com/apache/arrow-datafusion/pull/3323

   Signed-off-by: Ruihang Xia <wa...@gmail.com>
   
   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Ref #3321.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   GitHub Action will only run on PR updating, we cannot trigger one on demand manually. This is inconvenient if we want to run one on master or without submitting a PR.
   
   I've tried this patch in my fork repo, now I can see this button:
   ![image](https://user-images.githubusercontent.com/15380403/187865413-7b5f10c2-7b1f-4583-ae83-a00dde792fe5.png)
   
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Add an [action trigger](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch] that allows us to trigger an action manually.
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   No
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3323: MINOR: add github action trigger

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3323:
URL: https://github.com/apache/arrow-datafusion/pull/3323#discussion_r960668084


##########
.github/workflows/rust.yml:
##########
@@ -18,9 +18,11 @@
 name: Rust
 
 on:
-  # always trigger
+  # always trigger on PR
   push:
   pull_request:
+  # manual trigger
+  workflow_dispatch:

Review Comment:
   
   
   TIL https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch 
   



##########
.github/workflows/rust.yml:
##########
@@ -18,9 +18,11 @@
 name: Rust
 
 on:
-  # always trigger
+  # always trigger on PR
   push:
   pull_request:
+  # manual trigger

Review Comment:
   ```suggestion
     # manual trigger
     # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #3323: MINOR: add github action trigger

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #3323:
URL: https://github.com/apache/arrow-datafusion/pull/3323#issuecomment-1234236215

   test failure caused by https://github.com/apache/arrow-datafusion/issues/3327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #3323: MINOR: add github action trigger

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3323:
URL: https://github.com/apache/arrow-datafusion/pull/3323#issuecomment-1234297031

   Thanks @waynexia  -- this looks great. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ursabot commented on pull request #3323: MINOR: add github action trigger

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3323:
URL: https://github.com/apache/arrow-datafusion/pull/3323#issuecomment-1234527426

   Benchmark runs are scheduled for baseline = 70e702c01f07ac7fd7f25effda8267b375662b04 and contender = e0a765d97e57e8202ab1dc304280dd69d22754c5. e0a765d97e57e8202ab1dc304280dd69d22754c5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/93cd85b88e0c4d74b62fe5a3f08d8c0d...87d5458b7ecf4aa1a5b1bcb81ab5b3ff/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c9e027be4865404d8a918f97a7466fd7...7de98263a34e46e1a867fda766fdb448/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2e16574555c649adada49d20c7be4373...ef63712a821945deaa9d46823335c5f2/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/dd2500695c734684a4cb1f18f3012391...9ad3572626d047d681a39fc5c7ce1d9a/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] waynexia commented on pull request #3323: MINOR: add github action trigger

Posted by GitBox <gi...@apache.org>.
waynexia commented on PR #3323:
URL: https://github.com/apache/arrow-datafusion/pull/3323#issuecomment-1235217521

   Thanks ❤️ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3323: MINOR: add github action trigger

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3323:
URL: https://github.com/apache/arrow-datafusion/pull/3323#issuecomment-1234368045

   # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3323?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3323](https://codecov.io/gh/apache/arrow-datafusion/pull/3323?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9140639) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/70e702c01f07ac7fd7f25effda8267b375662b04?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70e702c) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #3323      +/-   ##
   ==========================================
   - Coverage   85.81%   85.81%   -0.01%     
   ==========================================
     Files         294      294              
     Lines       53764    53764              
   ==========================================
   - Hits        46136    46135       -1     
   - Misses       7628     7629       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `78.05% <0.00%> (-0.17%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #3323: MINOR: add github action trigger

Posted by GitBox <gi...@apache.org>.
alamb merged PR #3323:
URL: https://github.com/apache/arrow-datafusion/pull/3323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #3323: MINOR: add github action trigger

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3323:
URL: https://github.com/apache/arrow-datafusion/pull/3323#issuecomment-1234298681

   I took the liberty of merging this branch to master -- hope to merge it when green


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org