You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@continuum.apache.org by Emmanuel Venisse <em...@gmail.com> on 2009/10/06 10:35:38 UTC
Re: svn commit: r822134 - /continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
Thanks, I didn't see it
Emmanuel
On Tue, Oct 6, 2009 at 7:52 AM, <ct...@apache.org> wrote:
> Author: ctan
> Date: Tue Oct 6 05:52:47 2009
> New Revision: 822134
>
> URL: http://svn.apache.org/viewvc?rev=822134&view=rev
> Log:
> [CONTINUUM-1031] use getBuildResultsForProject instead of
> getProjectWithBuilds to improve performance when deleting a project
>
> Modified:
>
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
>
> Modified:
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> URL:
> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java?rev=822134&r1=822133&r2=822134&view=diff
>
> ==============================================================================
> ---
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> (original)
> +++
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> Tue Oct 6 05:52:47 2009
> @@ -591,7 +591,7 @@
> {
> try
> {
> - Project project = getProjectWithBuilds( projectId );
> + Project project = getProject( projectId );
>
> try
> {
> @@ -660,9 +660,10 @@
>
> log.info( "Remove project " + project.getName() + "(" +
> projectId + ")" );
>
> - for ( Object o : project.getBuildResults() )
> + Collection<BuildResult> buildResults =
> getBuildResultsForProject( projectId );
> +
> + for ( BuildResult br : buildResults )
> {
> - BuildResult br = (BuildResult) o;
> br.setBuildDefinition( null );
> //Remove all modified dependencies to prevent SQL errors
> br.setModifiedDependencies( null );
>
>
>
Re: svn commit: r822134 - /continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
Posted by Marica Tan <ma...@gmail.com>.
Sure np :)
On Tue, Oct 6, 2009 at 4:35 PM, Emmanuel Venisse <emmanuel.venisse@gmail.com
> wrote:
> Thanks, I didn't see it
>
> Emmanuel
>
> On Tue, Oct 6, 2009 at 7:52 AM, <ct...@apache.org> wrote:
>
> > Author: ctan
> > Date: Tue Oct 6 05:52:47 2009
> > New Revision: 822134
> >
> > URL: http://svn.apache.org/viewvc?rev=822134&view=rev
> > Log:
> > [CONTINUUM-1031] use getBuildResultsForProject instead of
> > getProjectWithBuilds to improve performance when deleting a project
> >
> > Modified:
> >
> >
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> >
> > Modified:
> >
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> > URL:
> >
> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java?rev=822134&r1=822133&r2=822134&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> > (original)
> > +++
> >
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> > Tue Oct 6 05:52:47 2009
> > @@ -591,7 +591,7 @@
> > {
> > try
> > {
> > - Project project = getProjectWithBuilds( projectId );
> > + Project project = getProject( projectId );
> >
> > try
> > {
> > @@ -660,9 +660,10 @@
> >
> > log.info( "Remove project " + project.getName() + "(" +
> > projectId + ")" );
> >
> > - for ( Object o : project.getBuildResults() )
> > + Collection<BuildResult> buildResults =
> > getBuildResultsForProject( projectId );
> > +
> > + for ( BuildResult br : buildResults )
> > {
> > - BuildResult br = (BuildResult) o;
> > br.setBuildDefinition( null );
> > //Remove all modified dependencies to prevent SQL errors
> > br.setModifiedDependencies( null );
> >
> >
> >
>