[jira] [Commented] (NIFI-4433) Remove duplicate dependency in nifi/pom.xml

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183579#comment-16183579 ] 

ASF GitHub Bot commented on NIFI-4433:
--------------------------------------

GitHub user alopresto opened a pull request:

    https://github.com/apache/nifi/pull/2182

    NIFI-4433 Resolved duplicate dependency declarations to remove warnin…

    …gs from `mvn dependency:list`.
    
    As noted in the Jira, over 1000 lines of warnings were generated when `mvn dependency:list` was run due to duplicate dependency declarations. These fixes remove that output. 
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alopresto/nifi NIFI-4433

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2182
    
----
commit 08e3a8ba04eb41ac45d249410713926fb499ae8f
Author: Andy LoPresto <al...@apache.org>
Date:   2017-09-28T02:24:29Z

    NIFI-4433 Resolved duplicate dependency declarations to remove warnings from `mvn dependency:list`.

----


> Remove duplicate dependency in nifi/pom.xml
> -------------------------------------------
>
>                 Key: NIFI-4433
>                 URL: https://issues.apache.org/jira/browse/NIFI-4433
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.4.0
>            Reporter: Andy LoPresto
>            Priority: Trivial
>              Labels: beginner, dependencies, maven
>
> When running {{mvn dependency:list}}, over 1000 lines of warnings are generated because of a duplicated dependency on {{nifi-mongodb-client-service-api}} in {{nifi/pom.xml}}. 
> Example:
> {code}
> [WARNING] Some problems were encountered while building the effective model for org.apache.nifi:nifi-toolkit:pom:1.4.0-SNAPSHOT
> [WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.apache.nifi:nifi-mongodb-client-service-api:jar -> duplicate declaration of version 1.4.0-SNAPSHOT @ org.apache.nifi:nifi:1.4.0-SNAPSHOT, /Users/alopresto/Workspace/nifi/pom.xml, line 1611, column 25
> [WARNING]
> {code}
> Removing the duplicate dependency at line 1611 (the original is at line 1051) should resolve this. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)