You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/04/11 19:37:12 UTC
Review Request 46039: AMBARI-15809 Web Client Does Not Expose
Parameters For All Alert Types
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46039/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15809
https://issues.apache.org/jira/browse/AMBARI-15809
Repository: ambari
Description
-------
AMBARI-15745 added a new SERVER type alert which exposes several parameters.
However, these parameters are not exposed via the web client. It seems like only parameters for SCRIPT alerts are exposed.
Diffs
-----
ambari-web/app/controllers/main/alerts/definition_configs_controller.js d5b27c5
Diff: https://reviews.apache.org/r/46039/diff/
Testing
-------
Local ambari-web test passed.
25640 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 46039: AMBARI-15809 Web Client Does Not Expose
Parameters For All Alert Types
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46039/#review128518
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On April 11, 2016, 5:37 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46039/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 5:37 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15809
> https://issues.apache.org/jira/browse/AMBARI-15809
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-15745 added a new SERVER type alert which exposes several parameters.
> However, these parameters are not exposed via the web client. It seems like only parameters for SCRIPT alerts are exposed.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/alerts/definition_configs_controller.js d5b27c5
>
> Diff: https://reviews.apache.org/r/46039/diff/
>
>
> Testing
> -------
>
> Local ambari-web test passed.
> 25640 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>