You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@gmail.com> on 2012/03/31 01:23:09 UTC

Review Request: FLUME-999: Rename node to agent in flume-ng script

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4577/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature.


This addresses bug FLUME-999.
    https://issues.apache.org/jira/browse/FLUME-999


Diffs
-----

  bin/flume-ng a31f171 

Diff: https://reviews.apache.org/r/4577/diff


Testing
-------

Tested invocation using both "node" and "agent".


Thanks,

Mike


Re: Review Request: FLUME-999: Rename node to agent in flume-ng script

Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4577/#review6614
-----------------------------------------------------------

Ship it!


- Arvind


On 2012-04-01 23:19:56, Mike Percy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4577/
> -----------------------------------------------------------
> 
> (Updated 2012-04-01 23:19:56)
> 
> 
> Review request for Flume.
> 
> 
> Summary
> -------
> 
> I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature.
> 
> 
> This addresses bug FLUME-999.
>     https://issues.apache.org/jira/browse/FLUME-999
> 
> 
> Diffs
> -----
> 
>   bin/flume-ng acde274 
> 
> Diff: https://reviews.apache.org/r/4577/diff
> 
> 
> Testing
> -------
> 
> Tested invocation using both "node" and "agent".
> 
> 
> Thanks,
> 
> Mike
> 
>


Re: Review Request: FLUME-999: Rename node to agent in flume-ng script

Posted by Mike Percy <mp...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4577/
-----------------------------------------------------------

(Updated 2012-04-01 23:19:56.861859)


Review request for Flume.


Changes
-------

Rebasing patch after recent changes to flume-ng script.


Summary
-------

I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature.


This addresses bug FLUME-999.
    https://issues.apache.org/jira/browse/FLUME-999


Diffs (updated)
-----

  bin/flume-ng acde274 

Diff: https://reviews.apache.org/r/4577/diff


Testing
-------

Tested invocation using both "node" and "agent".


Thanks,

Mike


Re: Review Request: FLUME-999: Rename node to agent in flume-ng script

Posted by Arvind Prabhakar <ar...@apache.org>.

> On 2012-03-31 02:33:49, Arvind Prabhakar wrote:
> > +1

Mike - can you please attach this patch to the Jira.


- Arvind


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4577/#review6599
-----------------------------------------------------------


On 2012-03-30 23:23:09, Mike Percy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4577/
> -----------------------------------------------------------
> 
> (Updated 2012-03-30 23:23:09)
> 
> 
> Review request for Flume.
> 
> 
> Summary
> -------
> 
> I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature.
> 
> 
> This addresses bug FLUME-999.
>     https://issues.apache.org/jira/browse/FLUME-999
> 
> 
> Diffs
> -----
> 
>   bin/flume-ng a31f171 
> 
> Diff: https://reviews.apache.org/r/4577/diff
> 
> 
> Testing
> -------
> 
> Tested invocation using both "node" and "agent".
> 
> 
> Thanks,
> 
> Mike
> 
>


Re: Review Request: FLUME-999: Rename node to agent in flume-ng script

Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4577/#review6599
-----------------------------------------------------------

Ship it!


+1

- Arvind


On 2012-03-30 23:23:09, Mike Percy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4577/
> -----------------------------------------------------------
> 
> (Updated 2012-03-30 23:23:09)
> 
> 
> Review request for Flume.
> 
> 
> Summary
> -------
> 
> I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature.
> 
> 
> This addresses bug FLUME-999.
>     https://issues.apache.org/jira/browse/FLUME-999
> 
> 
> Diffs
> -----
> 
>   bin/flume-ng a31f171 
> 
> Diff: https://reviews.apache.org/r/4577/diff
> 
> 
> Testing
> -------
> 
> Tested invocation using both "node" and "agent".
> 
> 
> Thanks,
> 
> Mike
> 
>