You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/29 20:23:53 UTC
[GitHub] [incubator-pinot] mqliang opened a new issue #6726: Bump up DataTable version and address TODOs in DataTableBuilders
mqliang opened a new issue #6726:
URL: https://github.com/apache/incubator-pinot/issues/6726
As discussed into: https://github.com/apache/incubator-pinot/pull/6710, we need bump up DataTable version to address TODOs in DataTableBuilders:
```
// TODO: potential optimizations:
// TODO: 1. Fix float size.
// TODO: 2. Use one dictionary for all columns (save space).
// TODO: 3. Given a data schema, write all values one by one instead of using rowId and colId to position (save time).
// TODO: 4. Store bytes as variable size data instead of String
```
For the 3rd TODO, it speculative and benchmark result shows it's not needed: https://github.com/apache/incubator-pinot/issues/6720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6726: Bump up DataTable version to address TODOs in DataTableBuilders
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #6726:
URL: https://github.com/apache/incubator-pinot/issues/6726#issuecomment-810628574
(Optional) For the 3rd TODO, we may simplify the code by replacing `setColumn(int colId, int value)` to `pubValue(int value)` because we always put values one by one. Performance difference might not be huge, but should be cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mqliang commented on issue #6726: Bump up DataTable version to address TODOs in DataTableBuilders
Posted by GitBox <gi...@apache.org>.
mqliang commented on issue #6726:
URL: https://github.com/apache/incubator-pinot/issues/6726#issuecomment-810646448
`AppendValue()` looks much better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang edited a comment on issue #6726: Bump up DataTable version to address TODOs in DataTableBuilders
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang edited a comment on issue #6726:
URL: https://github.com/apache/incubator-pinot/issues/6726#issuecomment-810628574
(Optional) For the 3rd TODO, we may simplify the code by replacing `setColumn(int colId, int value)` to `putValue(int value)` because we always put values one by one. Performance difference might not be huge, but should be cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org