You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2022/04/27 11:04:46 UTC

[whimsy] branch master updated: Lint

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 90498609 Lint
90498609 is described below

commit 90498609da03a10afa5a4cf6d8e9b0910ad03a42
Author: Sebb <se...@apache.org>
AuthorDate: Wed Apr 27 12:04:36 2022 +0100

    Lint
---
 www/roster/views/members.html.rb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/roster/views/members.html.rb b/www/roster/views/members.html.rb
index 6dfdd396..828be174 100644
--- a/www/roster/views/members.html.rb
+++ b/www/roster/views/members.html.rb
@@ -48,7 +48,7 @@ _html do
 
       # merge ldap info, preferring public names over name listed in members.txt
       ldap = ASF.members
-      preload = ASF::Person.preload('cn', ldap)
+      _preload = ASF::Person.preload('cn', ldap)
 
       ldap.each do |person|
         if members[person.id]
@@ -79,7 +79,7 @@ _html do
           end
 
           _tbody do
-            members.sort_by {|id, info| info[:name]}.each do |id, info|
+            members.sort_by {|_id, info| info[:name]}.each do |id, info|
               _tr_ do
                 _td! do
                   if ldap.include? ASF::Person.find(id)
@@ -87,7 +87,7 @@ _html do
                   else
                     _a id, href: "committer/#{id}"
 
-                    info[:issue] ||= 'Not in LDAP "member" group' if not info['status']
+                    info[:issue] ||= 'Not in LDAP "member" group' unless info['status']
                   end
                 end
 
@@ -95,7 +95,7 @@ _html do
 
                 if info[:issue]
                   _td.issue info[:issue]
-                elsif
+                else
                   _td info['status']
                 end
               end