You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/07/07 10:45:18 UTC
[GitHub] [solr-operator] gerlowskija opened a new pull request, #455: Recompute NextScheduled backup on each reconcile
gerlowskija opened a new pull request, #455:
URL: https://github.com/apache/solr-operator/pull/455
Resolves #376
Prior to this commit, the 'NextScheduled' field of a solrbackup's status
was never updated, even if the user the backup schedule in the
solrbackup spec.
This commit changes this: NextScheduled is now recomputed during each
reconciliation, as long as there is not an active backup ongoing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija commented on pull request #455: Recompute NextScheduled backup on each reconcile
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on PR #455:
URL: https://github.com/apache/solr-operator/pull/455#issuecomment-1180797762
> how the schedule gets restarted if the user disables the recurrence and then re-enables it
This fixes that "problem", yep. Prior to this PR, a backup would immediately be run upon re-enabling the `solrbackup`. With this PR, we now wait if the time indicated by `NextScheduled` hasn't arrived yet. (Of course, if NextScheduled has already come and gone when a solrbackup is re-enabled, we _will_ trigger a backup upon re-enabling.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on pull request #455: Recompute NextScheduled backup on each reconcile
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #455:
URL: https://github.com/apache/solr-operator/pull/455#issuecomment-1177905353
We were discussing offline about how the schedule gets restarted if the user disables the recurrence and then re-enables it. Does this fix that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija merged pull request #455: Recompute NextScheduled backup on each reconcile
Posted by GitBox <gi...@apache.org>.
gerlowskija merged PR #455:
URL: https://github.com/apache/solr-operator/pull/455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org