You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by pramodconflux <gi...@git.apache.org> on 2016/06/22 10:00:59 UTC
[GitHub] incubator-fineract pull request #155: FINERACT-177 individual client share i...
GitHub user pramodconflux opened a pull request:
https://github.com/apache/incubator-fineract/pull/155
FINERACT-177 individual client share in group loan
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pramodconflux/incubator-fineract individual_disbursed_amount_in_group_loan
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #155
----
commit 72da25f1cbb8df1a8ea18668d7c2a5c373e00e2a
Author: aj-ankitjain <aj...@gmail.com>
Date: 2016-06-22T09:58:59Z
FINERACT-177 individual client share in group loan
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #155: FINERACT-177 individual client share i...
Posted by pramodconflux <gi...@git.apache.org>.
Github user pramodconflux closed the pull request at:
https://github.com/apache/incubator-fineract/pull/155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #155: FINERACT-177 individual client share i...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/155#discussion_r73111971
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/GroupLoanIndividualMonitoringApiResource.java ---
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.portfolio.loanaccount.api;
+
+import java.util.Collection;
+
+import javax.ws.rs.Consumes;
+import javax.ws.rs.GET;
+import javax.ws.rs.Path;
+import javax.ws.rs.PathParam;
+import javax.ws.rs.Produces;
+import javax.ws.rs.core.Context;
+import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.UriInfo;
+
+import org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformService;
+import org.apache.fineract.infrastructure.core.api.ApiRequestParameterHelper;
+import org.apache.fineract.infrastructure.core.serialization.ApiRequestJsonSerializationSettings;
+import org.apache.fineract.infrastructure.core.serialization.DefaultToApiJsonSerializer;
+import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.Scope;
+import org.springframework.stereotype.Component;
+
+import org.apache.fineract.portfolio.loanaccount.data.GroupLoanIndividualMonitoringData;
+import org.apache.fineract.portfolio.loanaccount.service.GroupLoanIndividualMonitoringReadPlatformService;
+
+@Path("/grouploanindividualmonitoring")
+@Component
+@Scope("singleton")
+public class GroupLoanIndividualMonitoringApiResource {
+
+ private final PlatformSecurityContext context;
+ private final ApiRequestParameterHelper apiRequestParameterHelper;
+ private final DefaultToApiJsonSerializer<GroupLoanIndividualMonitoringData> toApiJsonSerializer;
+ private final PortfolioCommandSourceWritePlatformService commandsSourceWritePlatformService;
+ private final GroupLoanIndividualMonitoringReadPlatformService groupLoanIndividualMonitoringReadPlatformService;
+
+ @Autowired
+ public GroupLoanIndividualMonitoringApiResource(
+ final PlatformSecurityContext context,
+ final ApiRequestParameterHelper apiRequestParameterHelper,
+ final DefaultToApiJsonSerializer<GroupLoanIndividualMonitoringData> toApiJsonSerializer,
+ final PortfolioCommandSourceWritePlatformService commandsSourceWritePlatformService,
+ final GroupLoanIndividualMonitoringReadPlatformService groupLoanIndividualMonitoringReadPlatformService) {
+ this.context = context;
+ this.apiRequestParameterHelper = apiRequestParameterHelper;
+ this.toApiJsonSerializer = toApiJsonSerializer;
+ this.commandsSourceWritePlatformService = commandsSourceWritePlatformService;
+ this.groupLoanIndividualMonitoringReadPlatformService = groupLoanIndividualMonitoringReadPlatformService;
+ }
+
+ @GET
+ @Consumes({ MediaType.APPLICATION_JSON })
+ @Produces({ MediaType.APPLICATION_JSON })
+ public String retrieveAll(@Context final UriInfo uriInfo) {
--- End diff --
Better to give pagination support. Instead of giving complete data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #155: FINERACT-177 individual client share i...
Posted by pramodconflux <gi...@git.apache.org>.
GitHub user pramodconflux reopened a pull request:
https://github.com/apache/incubator-fineract/pull/155
FINERACT-177 individual client share in group loan
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pramodconflux/incubator-fineract individual_disbursed_amount_in_group_loan
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #155
----
commit 72da25f1cbb8df1a8ea18668d7c2a5c373e00e2a
Author: aj-ankitjain <aj...@gmail.com>
Date: 2016-06-22T09:58:59Z
FINERACT-177 individual client share in group loan
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---