You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/06 17:37:32 UTC

[GitHub] [airflow] nuclearpinguin opened a new pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

nuclearpinguin opened a new pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082
 
 
     Congratulations on your first Pull Request and welcome to the Apache Airflow community!
     If you have any issues or are unsure about any anything please check our
     Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   
     Here are some useful points:
     - Check the quality of your code (flake8, pylint and type annotations). Our [pre-commits](
     https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
     will help you with that.
     - In case of a new feature add useful documentation (in docstrings or in `docs/` directory).
     Adding a new operator? Consider adding an example DAG that shows how users should use it.
     - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst), it’s a
     heavy docker but it ships with a working Airflow and a lot of integrations.
     - Be patient and persistent.
   
     Apache Airflow is a community-driven project and together we are making it better 🚀
   
     In case of doubts contact the developers at:
     Mailing List: dev@airflow.apache.org
     Slack: https://apache-airflow-slack.herokuapp.com/
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082#discussion_r363404523
 
 

 ##########
 File path: .github/boring-cyborg.yml
 ##########
 @@ -152,6 +152,18 @@ firstPRWelcomeComment: |
   If you have any issues or are unsure about any anything please check our
   Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
 
+  Here are some useful points:
+  - Check the quality of your code (flake8, pylint and type annotations). Our [pre-commits](
 
 Review comment:
   ```suggestion
     - Pay attention to quality of your code (flake8, pylint and type annotations). Our [pre-commits](
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082#discussion_r363406826

##########
File path: .github/boring-cyborg.yml
##########
@@ -152,6 +152,18 @@ firstPRWelcomeComment: |
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)

+ Here are some useful points:
+ - Check the quality of your code (flake8, pylint and type annotations). Our [pre-commits](
+ https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
+ will help you with that.
+ - In case of a new feature add useful documentation (in docstrings or in `docs/` directory).
+ Adding a new operator? Consider adding an example DAG that shows how users should use it.
+ - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst), it’s a
+ heavy docker but it ships with a working Airflow and a lot of integrations.
+ - Be patient and persistent.
+
+ Apache Airflow is a community-driven project and together we are making it better 🚀

Review comment:
```suggestion
Apache Airflow is a community-driven project and together we are making it better 🚀.

Feel free to propose improvements once you get familiar with the way we work and you have some improvement ideas. Ideally you can even do such improvement yourself - this is the best way to start your journey towards becoming an Apache Airflow committer.
```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [airflow] kaxil edited a comment on issue #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

Posted by GitBox <gi...@apache.org>.

kaxil edited a comment on issue #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082#issuecomment-571246554
 
 
   Mergeable is failing: https://github.com/apache/airflow/pull/7082/checks?check_run_id=376054901 ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil merged pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

Posted by GitBox <gi...@apache.org>.

kaxil merged pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082#discussion_r363404278

Review comment:
take some time -> take some time and a number of iterations

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

Posted by GitBox <gi...@apache.org>.

kaxil commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082#discussion_r363402491
 
 

 ##########
 File path: .github/boring-cyborg.yml
 ##########
 @@ -152,6 +152,18 @@ firstPRWelcomeComment: |
   If you have any issues or are unsure about any anything please check our
   Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
 
+  Here are some useful points:
+  - Check the quality of your code (flake8, pylint and type annotations). Our [pre-commits](
+  https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
+  will help you with that.
+  - In case of a new feature add useful documentation (in docstrings or in `docs/` directory).
+  Adding a new operator? Consider adding an example DAG that shows how users should use it.
+  - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst), it’s a
 
 Review comment:
   ```suggestion
     - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

Posted by GitBox <gi...@apache.org>.

kaxil commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082#discussion_r363402379

Review comment:
```suggestion
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
```

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

Posted by GitBox <gi...@apache.org>.

kaxil commented on issue #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082#issuecomment-571249697
 
 
   Looks good, thanks @nuclearpinguin 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

Posted by GitBox <gi...@apache.org>.

kaxil commented on issue #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082#issuecomment-571246554
 
 
   Mereable is failing: https://github.com/apache/airflow/pull/7082/checks?check_run_id=376054901 ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services