You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/09/11 21:31:32 UTC
[GitHub] [helix] junkaixue opened a new pull request #1867: Fix error partition blocks load rebalance
junkaixue opened a new pull request #1867:
URL: https://github.com/apache/helix/pull/1867
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1866
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
There are three things fixed:
1. State priority is higher priority with smaller number.
2. When only downward is allowed, any non downward STs must be removed from message and throttled.
3. Even for downward STs should be respect to the throttling as backward compatible behavior.
### Tests
- [X] The following tests are written for this issue:
Add test case in TestReplicaLevelThrottling.java
- The following is the result of the "mvn test" command on the appropriate module:
TBD
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1867: Fix error partition blocks load rebalance
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1867:
URL: https://github.com/apache/helix/pull/1867#discussion_r707813374
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/IntermediateStateCalcStage.java
##########
@@ -520,8 +520,12 @@ private void loadRebalance(Resource resource, Partition partition,
ResourceControllerDataProvider cache,
boolean onlyDownwardLoadBalance, StateModelDefinition stateModelDefinition, Set<String> messagesThrottled,
Map<Partition, List<Message>> resourceMessageMap) {
- if (onlyDownwardLoadBalance && isLoadBalanceDownwardStateTransition(messageToThrottle, stateModelDefinition)) {
- // Remove the message already allowed for downward state transitions.
+ // If only downward allowed: 1) any non-downward ST messages will be throttled and removed.
+ // 2) any downward ST messages will respect the throttling.
+ // If not only downward allowed, all ST messages should respect the throttling.
+ if (onlyDownwardLoadBalance && !isLoadBalanceDownwardStateTransition(messageToThrottle, stateModelDefinition)) {
Review comment:
The change makes sense now. But ideally, I think we should let the throttling class handle extra logic like "onlyDownwardLoadBalance". I propose that we refactor this when deprecating the IntermediateStateCalcStage class. Please add a TODO here if you think it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on a change in pull request #1867: Fix error partition blocks load rebalance
Posted by GitBox <gi...@apache.org>.
junkaixue commented on a change in pull request #1867:
URL: https://github.com/apache/helix/pull/1867#discussion_r707862489
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/IntermediateStateCalcStage.java
##########
@@ -520,8 +520,12 @@ private void loadRebalance(Resource resource, Partition partition,
ResourceControllerDataProvider cache,
boolean onlyDownwardLoadBalance, StateModelDefinition stateModelDefinition, Set<String> messagesThrottled,
Map<Partition, List<Message>> resourceMessageMap) {
- if (onlyDownwardLoadBalance && isLoadBalanceDownwardStateTransition(messageToThrottle, stateModelDefinition)) {
- // Remove the message already allowed for downward state transitions.
+ // If only downward allowed: 1) any non-downward ST messages will be throttled and removed.
+ // 2) any downward ST messages will respect the throttling.
+ // If not only downward allowed, all ST messages should respect the throttling.
+ if (onlyDownwardLoadBalance && !isLoadBalanceDownwardStateTransition(messageToThrottle, stateModelDefinition)) {
Review comment:
Yeah. That makes sense to me. Will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #1867: Fix error partition blocks load rebalance
Posted by GitBox <gi...@apache.org>.
junkaixue merged pull request #1867:
URL: https://github.com/apache/helix/pull/1867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org