[beam] branch master updated: Pr-bot Don't count all reviews as approvals (#17269)

[lo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lostluck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 0c34a7da7be Pr-bot Don't count all reviews as approvals (#17269)
0c34a7da7be is described below

commit 0c34a7da7bebaa31224183444ea6215556f9da34
Author: Danny McCormick <da...@google.com>
AuthorDate: Mon Apr 4 15:23:01 2022 -0400

    Pr-bot Don't count all reviews as approvals (#17269)
---
 scripts/ci/pr-bot/processNewPrs.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/ci/pr-bot/processNewPrs.ts b/scripts/ci/pr-bot/processNewPrs.ts
index 67df232d37f..84351adc0ca 100644
--- a/scripts/ci/pr-bot/processNewPrs.ts
+++ b/scripts/ci/pr-bot/processNewPrs.ts
@@ -149,7 +149,9 @@ async function approvedBy(pull: any): Promise<string[]> {
     pull_number: pull.number,
   });
 
-  return reviews.data.map((review) => review.user.login);
+  return reviews.data
+    .filter((review) => review.state == "APPROVED")
+    .map((review) => review.user.login);
 }
 
 /*