You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/23 13:58:16 UTC
[GitHub] [maven-wrapper] nhojpatrick opened a new pull request #15: MWRAPPER-44 add MavenWrapperDownloader.java into distribution bin
nhojpatrick opened a new pull request #15:
URL: https://github.com/apache/maven-wrapper/pull/15
Should fix https://issues.apache.org/jira/browse/MWRAPPER-44.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] nhojpatrick commented on pull request #15: MWRAPPER-44 clean up MavenWrapperDownloader upon plugin execution
Posted by GitBox <gi...@apache.org>.
nhojpatrick commented on pull request #15:
URL: https://github.com/apache/maven-wrapper/pull/15#issuecomment-1020935232
Okay change of plan, original patch was wrong as didn't understand apache's maven wrapper introduced distributionType. This patch now MavenWrapperDownloader.class before installing maven wrapper, and if distributionType is not 'source' it will as delete MavenWrapperDownloader.java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] jorsol commented on pull request #15: MWRAPPER-44 clean up MavenWrapperDownloader upon plugin execution
Posted by GitBox <gi...@apache.org>.
jorsol commented on pull request #15:
URL: https://github.com/apache/maven-wrapper/pull/15#issuecomment-1021017140
Hi @nhojpatrick, thanks for your PR, I already worked on this in the PR https://github.com/apache/maven-wrapper/pull/13, it's a fairly large change with many other fixes, would you mind reviewing that PR to check if it works for you? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] nhojpatrick commented on pull request #15: MWRAPPER-44 clean up MavenWrapperDownloader upon plugin execution
Posted by GitBox <gi...@apache.org>.
nhojpatrick commented on pull request #15:
URL: https://github.com/apache/maven-wrapper/pull/15#issuecomment-1020935232
Okay change of plan, original patch was wrong as didn't understand apache's maven wrapper introduced distributionType. This patch now MavenWrapperDownloader.class before installing maven wrapper, and if distributionType is not 'source' it will as delete MavenWrapperDownloader.java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] nhojpatrick commented on pull request #15: MWRAPPER-44 clean up MavenWrapperDownloader upon plugin execution
Posted by GitBox <gi...@apache.org>.
nhojpatrick commented on pull request #15:
URL: https://github.com/apache/maven-wrapper/pull/15#issuecomment-1022726725
> Hi @nhojpatrick, thanks for your PR, I already worked on this in the PR #13, it's a fairly large change with many other fixes, would you mind reviewing that PR to check if it works for you? Thanks!
Hi @jorsol your `WrapperMojo.cleanup(Path)` achieves the same results. I was going to create a clean up method myself but wanted to get the fix raised with the change change and simplest diff to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] nhojpatrick commented on pull request #15: MWRAPPER-44 add MavenWrapperDownloader.java into distribution bin
Posted by GitBox <gi...@apache.org>.
nhojpatrick commented on pull request #15:
URL: https://github.com/apache/maven-wrapper/pull/15#issuecomment-1019496232
So reading more documentation and have just discovered `-Dtype`. Should multiple mvnw[Debug][.cmd] be created, otherwise if you do `mvn wrapper:wrapper -Dtype=bin` it might try and execute MavenWrapperDownloader.class as a backup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] jorsol commented on pull request #15: MWRAPPER-44 clean up MavenWrapperDownloader upon plugin execution
Posted by GitBox <gi...@apache.org>.
jorsol commented on pull request #15:
URL: https://github.com/apache/maven-wrapper/pull/15#issuecomment-1021017140
Hi @nhojpatrick, thanks for your PR, I already worked on this in the PR https://github.com/apache/maven-wrapper/pull/13, it's a fairly large change with many other fixes, would you mind reviewing that PR to check if it works for you? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] nhojpatrick edited a comment on pull request #15: MWRAPPER-44 clean up MavenWrapperDownloader upon plugin execution
Posted by GitBox <gi...@apache.org>.
nhojpatrick edited a comment on pull request #15:
URL: https://github.com/apache/maven-wrapper/pull/15#issuecomment-1022726725
> Hi @nhojpatrick, thanks for your PR, I already worked on this in the PR #13, it's a fairly large change with many other fixes, would you mind reviewing that PR to check if it works for you? Thanks!
Hi @jorsol your `WrapperMojo.cleanup(Path)` achieves the same results. I was going to create a clean up method myself but wanted to get the fix raised with the change raised with the simplest diff to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org