You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "liutang123 (via GitHub)" <gi...@apache.org> on 2025/05/07 02:24:07 UTC
[PR] [feature](meta) Support specifying column encoding [doris]
liutang123 opened a new pull request, #50632:
URL: https://github.com/apache/doris/pull/50632
### What problem does this PR solve?
Issue Number: close #50631
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2874910700
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/e3f8a24967f275ad7dd0da83ac2e6ee1490f8c96_e3f8a24967f275ad7dd0da83ac2e6ee1490f8c96_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/e3f8a24967f275ad7dd0da83ac2e6ee1490f8c96_e3f8a24967f275ad7dd0da83ac2e6ee1490f8c96_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.20% (1104/1327) |
| Line Coverage | 66.14% (18581/28095) |
| Region Coverage | 65.75% (9254/14074) |
| Branch Coverage | 55.50% (4973/8960) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2876226198
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2876601651
<details>
<summary>TPC-H: <b>Total hot run time: 34060 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 481127d2219d4816c956b0c3811f9b6acd1dd9db, data reload: false
------ Round 1 ----------------------------------
q1 26565 5071 5060 5060
q2 2102 290 191 191
q3 10642 1260 730 730
q4 10262 1003 533 533
q5 7980 2275 2353 2275
q6 181 167 133 133
q7 901 732 617 617
q8 9324 1298 1100 1100
q9 6811 5121 5145 5121
q10 6820 2310 1919 1919
q11 477 285 271 271
q12 358 359 214 214
q13 17777 3683 3075 3075
q14 237 244 222 222
q15 540 477 506 477
q16 416 441 371 371
q17 601 871 371 371
q18 7895 7296 7157 7157
q19 1747 951 581 581
q20 353 328 223 223
q21 3857 3341 2485 2485
q22 1084 1026 934 934
Total cold run time: 116930 ms
Total hot run time: 34060 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5207 5098 5075 5075
q2 243 337 229 229
q3 2147 2649 2310 2310
q4 1370 1838 1546 1546
q5 4535 4502 4329 4329
q6 210 166 128 128
q7 1970 1918 1754 1754
q8 2576 2468 2476 2468
q9 7128 7054 7244 7054
q10 3041 3202 2751 2751
q11 577 517 482 482
q12 696 758 608 608
q13 3495 3860 3289 3289
q14 283 314 276 276
q15 539 493 475 475
q16 445 493 435 435
q17 1178 1491 1350 1350
q18 7759 7518 7322 7322
q19 802 817 903 817
q20 1990 2035 1845 1845
q21 5070 4672 4601 4601
q22 1080 1028 1007 1007
Total cold run time: 52341 ms
Total hot run time: 50151 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2876985566
# BE UT Coverage Report
Increment line coverage `31.82% (14/44)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/481127d2219d4816c956b0c3811f9b6acd1dd9db_481127d2219d4816c956b0c3811f9b6acd1dd9db/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/481127d2219d4816c956b0c3811f9b6acd1dd9db_481127d2219d4816c956b0c3811f9b6acd1dd9db/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.83% (14906/26701) |
| Line Coverage | 44.62% (131899/295618) |
| Region Coverage | 43.67% (66320/151870) |
| Branch Coverage | 38.29% (33989/88776) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-3736497855
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2874881713
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875229709
run buildadd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875473494
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2876673998
<details>
<summary>ClickBench: <b>Total hot run time: 28.86 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 481127d2219d4816c956b0c3811f9b6acd1dd9db, data reload: false
query1 0.03 0.03 0.04
query2 0.13 0.11 0.13
query3 0.25 0.20 0.20
query4 1.60 0.19 0.20
query5 0.60 0.59 0.58
query6 1.20 0.73 0.72
query7 0.02 0.02 0.02
query8 0.04 0.04 0.04
query9 0.58 0.53 0.52
query10 0.57 0.57 0.57
query11 0.16 0.11 0.12
query12 0.15 0.12 0.12
query13 0.61 0.60 0.59
query14 0.78 0.79 0.83
query15 0.89 0.84 0.86
query16 0.38 0.39 0.39
query17 1.06 1.05 1.08
query18 0.22 0.21 0.21
query19 1.93 1.80 1.75
query20 0.01 0.01 0.01
query21 15.40 0.91 0.53
query22 0.75 0.97 0.63
query23 15.15 1.39 0.62
query24 6.70 1.11 0.34
query25 0.37 0.20 0.12
query26 0.61 0.17 0.15
query27 0.05 0.04 0.06
query28 9.38 0.96 0.44
query29 12.55 4.07 3.31
query30 0.25 0.09 0.06
query31 2.83 0.61 0.40
query32 3.23 0.56 0.47
query33 3.05 3.13 3.07
query34 15.91 5.17 4.51
query35 4.56 4.56 4.54
query36 0.68 0.50 0.48
query37 0.09 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.02 0.02
query40 0.17 0.15 0.13
query41 0.08 0.04 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.17 s
Total hot run time: 28.86 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on code in PR #50632:
URL: https://github.com/apache/doris/pull/50632#discussion_r2165580654
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -4298,19 +4299,21 @@ private ExplainLevel parseExplainPlanType(PlanTypeContext planTypeContext) {
}
@Override
- public Pair<DataType, Boolean> visitDataTypeWithNullable(DataTypeWithNullableContext ctx) {
+ public Pair<TypeAndEncoding, Boolean> visitDataTypeWithNullable(DataTypeWithNullableContext ctx) {
return ParserUtils.withOrigin(ctx, () -> Pair.of(typedVisit(ctx.dataType()), ctx.NOT() == null));
}
@Override
- public DataType visitAggStateDataType(AggStateDataTypeContext ctx) {
+ public TypeAndEncoding visitAggStateDataType(AggStateDataTypeContext ctx) {
return ParserUtils.withOrigin(ctx, () -> {
- List<Pair<DataType, Boolean>> dataTypeWithNullables = ctx.dataTypes.stream()
+ List<Pair<TypeAndEncoding, Boolean>> dataTypeWithNullables = ctx.dataTypes.stream()
Review Comment:
The same as CastDataType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875952129
<details>
<summary>ClickBench: <b>Total hot run time: 29.99 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e7ffdfea3d8b796a754e02d269638f4536d1a9d5, data reload: false
query1 0.04 0.04 0.03
query2 0.14 0.11 0.12
query3 0.34 0.20 0.19
query4 1.59 0.20 0.20
query5 0.62 0.59 0.62
query6 1.20 0.72 0.73
query7 0.02 0.02 0.02
query8 0.05 0.04 0.05
query9 0.63 0.52 0.52
query10 0.57 0.58 0.57
query11 0.25 0.13 0.13
query12 0.26 0.13 0.14
query13 0.64 0.63 0.61
query14 0.80 0.82 0.83
query15 0.96 0.88 0.87
query16 0.36 0.37 0.37
query17 1.05 1.04 1.03
query18 0.18 0.18 0.18
query19 2.00 1.84 1.87
query20 0.02 0.02 0.01
query21 15.42 0.95 0.66
query22 0.92 1.03 0.82
query23 14.71 1.53 0.73
query24 5.51 0.57 0.28
query25 0.17 0.10 0.09
query26 0.55 0.21 0.18
query27 0.08 0.08 0.08
query28 11.02 1.14 0.59
query29 12.59 4.06 3.41
query30 0.27 0.08 0.08
query31 2.83 0.64 0.44
query32 3.24 0.60 0.51
query33 3.06 3.12 3.08
query34 16.59 5.08 4.47
query35 4.43 4.43 4.44
query36 0.64 0.53 0.49
query37 0.19 0.18 0.18
query38 0.17 0.15 0.16
query39 0.05 0.05 0.04
query40 0.21 0.16 0.16
query41 0.10 0.06 0.05
query42 0.07 0.06 0.05
query43 0.05 0.05 0.04
Total cold run time: 104.59 s
Total hot run time: 29.99 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on code in PR #50632:
URL: https://github.com/apache/doris/pull/50632#discussion_r2165587095
##########
fe/fe-common/src/main/java/org/apache/doris/catalog/EncodingTree.java:
##########
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.catalog;
+
+import lombok.Getter;
+
+import java.util.List;
+
+public class EncodingTree {
+ @Getter
+ private final int encodingNumber;
+ private final List<EncodingTree> children;
Review Comment:
Because encoding is not a `Type`'s param.
Both `Type` and encoding are `Column`'s param.
We use a `Type` tree and a encoding tree to construct the `Column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2914688932
should consider how schema change handle the new column encoding feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875548138
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/e7ffdfea3d8b796a754e02d269638f4536d1a9d5_e7ffdfea3d8b796a754e02d269638f4536d1a9d5_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/e7ffdfea3d8b796a754e02d269638f4536d1a9d5_e7ffdfea3d8b796a754e02d269638f4536d1a9d5_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.20% (1104/1327) |
| Line Coverage | 66.13% (18605/28136) |
| Region Coverage | 65.69% (9261/14098) |
| Branch Coverage | 55.41% (4977/8982) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875221024
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2892709561
1. Organize cases based on a mind map.
2. Cross features like backup restore, ccr.
3. Add cases for hidden columns like seq and delete sign.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2856832879
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875221211
run beut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875039460
<details>
<summary>TPC-DS: <b>Total hot run time: 187981 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e3f8a24967f275ad7dd0da83ac2e6ee1490f8c96, data reload: false
query1 1016 491 500 491
query2 6561 1844 1864 1844
query3 6751 244 220 220
query4 26176 24100 23445 23445
query5 4432 683 487 487
query6 320 221 195 195
query7 4640 498 309 309
query8 310 255 246 246
query9 8588 2627 2645 2627
query10 469 333 276 276
query11 16118 15085 14846 14846
query12 172 112 105 105
query13 1662 552 455 455
query14 9472 6200 6222 6200
query15 209 185 167 167
query16 7240 625 467 467
query17 1183 734 594 594
query18 1978 402 296 296
query19 183 188 162 162
query20 127 126 124 124
query21 218 129 109 109
query22 4045 4121 4052 4052
query23 34103 33325 33076 33076
query24 8464 2403 2379 2379
query25 551 458 416 416
query26 1238 269 159 159
query27 2749 510 339 339
query28 4321 2128 2100 2100
query29 784 558 448 448
query30 285 229 188 188
query31 947 863 772 772
query32 74 63 68 63
query33 557 362 336 336
query34 828 856 531 531
query35 782 793 718 718
query36 980 993 878 878
query37 118 111 74 74
query38 4230 4143 4170 4143
query39 1455 1592 1405 1405
query40 212 119 109 109
query41 70 53 52 52
query42 119 112 108 108
query43 523 518 479 479
query44 1280 812 817 812
query45 180 176 172 172
query46 853 1035 639 639
query47 1760 1784 1783 1783
query48 387 421 320 320
query49 779 528 424 424
query50 652 671 397 397
query51 4238 4175 4109 4109
query52 115 110 104 104
query53 249 254 188 188
query54 600 591 535 535
query55 91 92 90 90
query56 318 333 318 318
query57 1171 1153 1087 1087
query58 278 278 266 266
query59 2628 2856 2694 2694
query60 344 360 334 334
query61 156 166 184 166
query62 772 743 661 661
query63 229 193 190 190
query64 4404 1018 661 661
query65 4306 4234 4231 4231
query66 1126 441 314 314
query67 16004 15751 15580 15580
query68 7861 905 521 521
query69 478 309 277 277
query70 1182 1112 1121 1112
query71 472 336 314 314
query72 5732 4807 4993 4807
query73 700 647 360 360
query74 8897 9167 8976 8976
query75 3941 3249 2745 2745
query76 3560 1191 780 780
query77 779 395 300 300
query78 10103 10169 9447 9447
query79 2269 855 582 582
query80 586 528 449 449
query81 469 260 219 219
query82 454 128 98 98
query83 265 256 230 230
query84 244 101 96 96
query85 801 363 314 314
query86 390 335 301 301
query87 4405 4525 4392 4392
query88 3648 2280 2276 2276
query89 384 313 300 300
query90 1877 216 223 216
query91 139 140 114 114
query92 73 60 58 58
query93 1822 936 579 579
query94 683 402 304 304
query95 388 300 282 282
query96 495 589 287 287
query97 3217 3271 3215 3215
query98 232 228 206 206
query99 1445 1417 1259 1259
Total cold run time: 276171 ms
Total hot run time: 187981 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2876211166
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2872784805
<details>
<summary>ClickBench: <b>Total hot run time: 29.82 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1df829718fd3161920e598f5835002f7ab907669, data reload: false
query1 0.04 0.04 0.03
query2 0.13 0.10 0.11
query3 0.27 0.19 0.20
query4 1.59 0.20 0.20
query5 0.57 0.58 0.55
query6 1.21 0.72 0.73
query7 0.03 0.01 0.02
query8 0.04 0.03 0.03
query9 0.58 0.52 0.51
query10 0.58 0.58 0.57
query11 0.16 0.12 0.11
query12 0.15 0.12 0.12
query13 0.62 0.61 0.60
query14 0.79 0.81 0.81
query15 0.88 0.86 0.88
query16 0.41 0.39 0.38
query17 1.06 1.07 1.08
query18 0.22 0.22 0.21
query19 2.02 1.87 1.79
query20 0.01 0.01 0.01
query21 15.50 0.92 0.56
query22 0.76 1.08 0.63
query23 15.08 1.40 0.58
query24 6.89 1.82 1.27
query25 0.50 0.17 0.23
query26 0.54 0.16 0.15
query27 0.06 0.05 0.05
query28 10.43 0.92 0.45
query29 12.64 4.02 3.35
query30 0.25 0.09 0.06
query31 2.83 0.61 0.39
query32 3.23 0.56 0.47
query33 3.04 3.03 3.12
query34 15.75 5.13 4.49
query35 4.52 4.50 4.49
query36 0.66 0.50 0.48
query37 0.09 0.07 0.07
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.17 0.14 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 104.53 s
Total hot run time: 29.82 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2876651193
<details>
<summary>TPC-DS: <b>Total hot run time: 186475 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 481127d2219d4816c956b0c3811f9b6acd1dd9db, data reload: false
query1 1029 462 485 462
query2 6615 1822 1831 1822
query3 6750 226 218 218
query4 26734 23866 23047 23047
query5 4334 633 464 464
query6 301 223 204 204
query7 4629 488 283 283
query8 280 239 234 234
query9 8607 2634 2629 2629
query10 491 346 264 264
query11 15246 15009 14786 14786
query12 157 114 109 109
query13 1666 531 422 422
query14 8560 6225 6191 6191
query15 208 194 180 180
query16 7154 646 497 497
query17 1101 735 613 613
query18 1981 409 321 321
query19 204 193 166 166
query20 126 118 117 117
query21 211 124 110 110
query22 4190 4422 4168 4168
query23 34205 33084 33054 33054
query24 8458 2406 2461 2406
query25 539 454 400 400
query26 1234 270 195 195
query27 2701 498 345 345
query28 4340 2113 2084 2084
query29 763 546 434 434
query30 279 214 185 185
query31 905 868 752 752
query32 73 67 61 61
query33 568 372 313 313
query34 785 855 517 517
query35 783 861 721 721
query36 927 997 906 906
query37 104 98 74 74
query38 4119 4056 4019 4019
query39 1457 1434 1411 1411
query40 212 118 109 109
query41 60 52 52 52
query42 120 103 109 103
query43 516 498 475 475
query44 1285 817 806 806
query45 171 170 165 165
query46 864 1020 635 635
query47 1765 1845 1745 1745
query48 381 436 314 314
query49 755 517 425 425
query50 628 683 404 404
query51 4159 4115 4109 4109
query52 116 106 99 99
query53 222 250 186 186
query54 595 571 514 514
query55 83 81 81 81
query56 316 301 286 286
query57 1118 1170 1087 1087
query58 294 263 253 253
query59 2618 2858 2557 2557
query60 334 339 302 302
query61 129 122 123 122
query62 785 733 691 691
query63 224 182 189 182
query64 4362 1005 672 672
query65 4311 4286 4207 4207
query66 1151 415 319 319
query67 15928 15760 15540 15540
query68 8507 879 520 520
query69 478 306 270 270
query70 1226 1134 1120 1120
query71 454 348 300 300
query72 5647 4789 4888 4789
query73 748 652 353 353
query74 8913 8918 8728 8728
query75 4082 3251 2700 2700
query76 3774 1202 745 745
query77 790 366 286 286
query78 10048 10260 9436 9436
query79 2254 794 593 593
query80 583 521 436 436
query81 467 266 220 220
query82 426 129 101 101
query83 282 252 235 235
query84 298 119 87 87
query85 792 362 311 311
query86 335 306 303 303
query87 4456 4512 4307 4307
query88 3358 2338 2310 2310
query89 386 317 295 295
query90 1922 206 204 204
query91 142 146 110 110
query92 78 59 62 59
query93 1730 963 583 583
query94 676 390 301 301
query95 431 288 281 281
query96 486 568 278 278
query97 3224 3255 3126 3126
query98 234 207 207 207
query99 1453 1434 1257 1257
Total cold run time: 274996 ms
Total hot run time: 186475 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875939223
<details>
<summary>TPC-DS: <b>Total hot run time: 192807 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e7ffdfea3d8b796a754e02d269638f4536d1a9d5, data reload: false
query1 1412 1096 1068 1068
query2 6132 1804 1845 1804
query3 11023 4486 4540 4486
query4 54360 24723 23216 23216
query5 5000 527 466 466
query6 337 207 196 196
query7 4883 498 307 307
query8 320 255 241 241
query9 5245 2612 2630 2612
query10 386 322 272 272
query11 15066 14988 14772 14772
query12 165 114 110 110
query13 1051 532 400 400
query14 10150 6325 6253 6253
query15 211 220 191 191
query16 7207 653 487 487
query17 1086 758 591 591
query18 1703 414 324 324
query19 210 239 178 178
query20 136 124 123 123
query21 208 129 112 112
query22 4274 4382 4369 4369
query23 34541 33721 33502 33502
query24 6705 2502 2428 2428
query25 467 489 421 421
query26 706 274 162 162
query27 2365 502 358 358
query28 3293 2149 2134 2134
query29 584 566 447 447
query30 272 215 185 185
query31 863 870 821 821
query32 97 65 57 57
query33 440 368 307 307
query34 804 875 536 536
query35 816 849 776 776
query36 944 1007 905 905
query37 110 97 82 82
query38 4276 4391 4173 4173
query39 1534 1461 1476 1461
query40 207 117 111 111
query41 55 55 54 54
query42 128 112 111 111
query43 513 484 488 484
query44 1355 823 815 815
query45 180 182 164 164
query46 852 1027 649 649
query47 1847 1934 1804 1804
query48 386 445 320 320
query49 670 511 427 427
query50 688 709 407 407
query51 4279 4270 4203 4203
query52 114 115 105 105
query53 238 264 191 191
query54 608 611 525 525
query55 79 86 82 82
query56 318 309 304 304
query57 1199 1196 1139 1139
query58 271 263 262 262
query59 2711 2896 2714 2714
query60 345 351 316 316
query61 157 125 133 125
query62 738 756 702 702
query63 225 187 195 187
query64 1832 1040 682 682
query65 4291 4202 4226 4202
query66 739 396 317 317
query67 16065 15536 15329 15329
query68 7622 836 523 523
query69 533 299 271 271
query70 1174 1123 1102 1102
query71 488 330 301 301
query72 5782 4915 4905 4905
query73 1517 713 355 355
query74 8962 9081 8640 8640
query75 3858 3236 2694 2694
query76 4255 1202 748 748
query77 627 368 279 279
query78 10207 10218 9399 9399
query79 2417 801 589 589
query80 614 532 436 436
query81 478 268 215 215
query82 413 126 94 94
query83 372 251 234 234
query84 286 106 86 86
query85 803 351 327 327
query86 376 301 291 291
query87 4319 4465 4329 4329
query88 3175 2259 2265 2259
query89 397 316 276 276
query90 1951 201 205 201
query91 142 151 110 110
query92 79 104 55 55
query93 1235 952 583 583
query94 684 408 297 297
query95 364 290 288 288
query96 497 573 280 280
query97 3206 3241 3093 3093
query98 244 215 207 207
query99 1457 1401 1276 1276
Total cold run time: 299006 ms
Total hot run time: 192807 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875903859
<details>
<summary>TPC-H: <b>Total hot run time: 33902 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e7ffdfea3d8b796a754e02d269638f4536d1a9d5, data reload: false
------ Round 1 ----------------------------------
q1 26386 5048 5029 5029
q2 2072 282 183 183
q3 10595 1303 713 713
q4 10257 1000 530 530
q5 7911 2378 2375 2375
q6 182 166 142 142
q7 906 750 635 635
q8 9330 1343 1078 1078
q9 6851 5161 5073 5073
q10 6890 2311 1883 1883
q11 489 285 279 279
q12 349 347 207 207
q13 17816 3689 3092 3092
q14 233 248 219 219
q15 536 495 468 468
q16 428 428 398 398
q17 589 863 366 366
q18 7730 7294 7075 7075
q19 1612 964 570 570
q20 323 335 220 220
q21 3983 2635 2412 2412
q22 1053 1039 955 955
Total cold run time: 116521 ms
Total hot run time: 33902 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5274 5103 5121 5103
q2 241 332 228 228
q3 2178 2643 2302 2302
q4 1352 1794 1444 1444
q5 4497 4471 4415 4415
q6 216 163 135 135
q7 2021 1923 1788 1788
q8 2609 2674 2562 2562
q9 7319 7294 7016 7016
q10 3057 3190 2736 2736
q11 590 512 495 495
q12 662 776 614 614
q13 3557 3884 3286 3286
q14 286 305 281 281
q15 552 492 472 472
q16 442 476 434 434
q17 1173 1527 1454 1454
q18 7760 7568 7419 7419
q19 831 866 938 866
q20 2020 2021 1851 1851
q21 5095 4739 4739 4739
q22 1085 1064 1031 1031
Total cold run time: 52817 ms
Total hot run time: 50671 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2872431753
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/1df829718fd3161920e598f5835002f7ab907669_1df829718fd3161920e598f5835002f7ab907669_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/1df829718fd3161920e598f5835002f7ab907669_1df829718fd3161920e598f5835002f7ab907669_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.20% (1104/1327) |
| Line Coverage | 66.21% (18601/28095) |
| Region Coverage | 65.83% (9265/14074) |
| Branch Coverage | 55.60% (4982/8960) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2872765701
<details>
<summary>TPC-DS: <b>Total hot run time: 180729 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1df829718fd3161920e598f5835002f7ab907669, data reload: false
inventory Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:57 2023-12-26 22:50:32 NULL utf-8 NULL NULL
store Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:59 2023-12-26 22:44:01 NULL utf-8 NULL NULL
catalog_returns Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:57 2023-12-26 22:46:25 NULL utf-8 NULL NULL
time_dim Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:59 2023-12-26 22:44:03 NULL utf-8 NULL NULL
household_demographics Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:01 NULL utf-8 NULL NULL
store_sales Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:59 2023-12-26 22:59:20 NULL utf-8 NULL NULL
ship_mode Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:44:00 2023-12-26 22:44:05 NULL utf-8 NULL NULL
customer_address Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:41 NULL utf-8 NULL NULL
customer Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:44:00 2023-12-26 22:44:53 NULL utf-8 NULL NULL
web_returns Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:45:43 NULL utf-8 NULL NULL
warehouse Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:56 2023-12-26 22:44:01 NULL utf-8 NULL NULL
web_site Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:01 NULL utf-8 NULL NULL
customer_demographics Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:56 2023-12-26 22:44:34 NULL utf-8 NULL NULL
promotion Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:01 NULL utf-8 NULL NULL
web_page Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:59 2023-12-26 22:44:01 NULL utf-8 NULL NULL
store_returns Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:59 2023-12-26 22:47:09 NULL utf-8 NULL NULL
income_band Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:01 NULL utf-8 NULL NULL
dbgen_version Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:44:00 2023-12-26 22:44:01 NULL utf-8 NULL NULL
catalog_page Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:58 2023-12-26 22:44:01 NULL utf-8 NULL NULL
reason Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 22:43:56 2023-12-26 22:44:01 NULL utf-8 NULL NULL
============================================
query1 1028 494 493 493
query2 6583 1927 1907 1907
query3 6762 235 226 226
query4 26878 23979 23439 23439
query5 query6 332 228 208 208
query7 4645 485 295 295
query8 320 261 241 241
query9 8799 2644 2648 2644
query10 583 322 326 322
query11 15538 15194 14947 14947
query12 query13 1642 559 413 413
query14 10525 6403 6380 6380
query15 204 192 181 181
query16 query17 1636 766 594 594
query18 query19 213 195 159 159
query20 query21 query22 4188 4249 4004 4004
query23 33933 33139 33180 33139
query24 8687 2385 2422 2385
query25 661 453 385 385
query26 1392 285 157 157
query27 2757 507 336 336
query28 4470 2152 2113 2113
query29 883 589 459 459
query30 376 221 191 191
query31 961 843 776 776
query32 query33 608 380 327 327
query34 812 867 545 545
query35 785 837 735 735
query36 965 995 879 879
query37 query38 4155 4204 4196 4196
query39 1446 1449 1441 1441
query40 query41 63 55 55 55
query42 123 112 113 112
query43 526 508 496 496
query44 1349 842 844 842
query45 185 172 168 168
query46 867 1020 677 677
query47 1758 1776 1703 1703
query48 407 431 317 317
query49 query50 648 679 407 407
query51 4107 4173 4196 4173
query52 117 111 111 111
query53 228 252 184 184
query54 query55 84 91 97 91
query56 307 321 310 310
query57 1175 1153 1091 1091
query58 295 280 276 276
query59 2691 2804 2674 2674
query60 358 339 343 339
query61 query62 835 722 656 656
query63 241 195 196 195
query64 5795 1127 783 783
query65 4354 4292 4233 4233
query66 1888 449 351 351
query67 16069 15605 15383 15383
query68 6714 907 539 539
query69 482 318 278 278
query70 1188 1122 1133 1122
query71 434 324 303 303
query72 6417 4902 4891 4891
query73 705 701 359 359
query74 8917 9134 8758 8758
query75 query76 5407 1230 824 824
query77 query78 9957 9944 9330 9330
query79 2368 820 597 597
query80 query81 562 270 228 228
query82 query83 417 263 316 263
query84 245 114 108 108
query85 870 355 313 313
query86 401 317 279 279
query87 4520 4446 4335 4335
query88 3578 2334 2325 2325
query89 383 314 288 288
query90 query91 183 136 115 115
query92 query93 2431 915 600 600
query94 query95 query96 498 583 290 290
query97 3233 3245 3139 3139
query98 query99 1468 1405 1301 1301
Total cold run time: 258615 ms
Total hot run time: 180729 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #50632: [feature](meta) Support specifying column encoding
URL: https://github.com/apache/doris/pull/50632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2872719589
<details>
<summary>TPC-H: <b>Total hot run time: 33578 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1df829718fd3161920e598f5835002f7ab907669, data reload: false
------ Round 1 ----------------------------------
============================================
q1 26973 5029 5028 5028
q2 2071 287 199 199
q3 10628 1269 727 727
q4 10235 1042 541 541
q5 7949 2377 2393 2377
q6 184 165 133 133
q7 930 759 603 603
q8 9315 1312 1088 1088
q9 6795 5033 5133 5033
q10 6822 2343 1882 1882
q11 479 284 283 283
q12 347 352 206 206
q13 17774 3712 3121 3121
q14 231 241 224 224
q15 q16 416 429 397 397
q17 602 893 370 370
q18 7731 7281 7103 7103
q19 1605 958 547 547
q20 329 324 221 221
q21 4068 3463 2504 2504
q22 1017 1009 991 991
Total cold run time: 116501 ms
Total hot run time: 33578 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 5138 5066 5084 5066
q2 248 326 240 240
q3 2220 2652 2311 2311
q4 1337 1819 1341 1341
q5 4289 4244 4135 4135
q6 208 166 126 126
q7 1880 1818 1697 1697
q8 2545 2469 2409 2409
q9 6793 6784 6953 6784
q10 2870 3084 2677 2677
q11 571 523 487 487
q12 689 732 579 579
q13 3361 3726 3132 3132
q14 272 307 255 255
q15 q16 420 475 426 426
q17 1114 1399 1372 1372
q18 7454 7120 7249 7120
q19 754 772 873 772
q20 1939 1988 1827 1827
q21 5122 4733 4617 4617
q22 1085 1046 970 970
Total cold run time: 50309 ms
Total hot run time: 48343 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2876266764
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/481127d2219d4816c956b0c3811f9b6acd1dd9db_481127d2219d4816c956b0c3811f9b6acd1dd9db_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/481127d2219d4816c956b0c3811f9b6acd1dd9db_481127d2219d4816c956b0c3811f9b6acd1dd9db_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.20% (1104/1327) |
| Line Coverage | 66.17% (18618/28136) |
| Region Coverage | 65.75% (9269/14098) |
| Branch Coverage | 55.49% (4984/8982) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2872300069
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #50632:
URL: https://github.com/apache/doris/pull/50632#discussion_r2108681520
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -1691,7 +1691,7 @@ dataType
LEFT_PAREN dataTypes+=dataTypeWithNullable
(COMMA dataTypes+=dataTypeWithNullable)* RIGHT_PAREN GT #aggStateDataType
| primitiveColType (LEFT_PAREN (INTEGER_VALUE | ASTERISK)
- (COMMA INTEGER_VALUE)* RIGHT_PAREN)? #primitiveDataType
+ (COMMA INTEGER_VALUE)* RIGHT_PAREN)? (ENCODING encoding=STRING_LITERAL)? #primitiveDataType
Review Comment:
```suggestion
(COMMA INTEGER_VALUE)* RIGHT_PAREN)?
(ENCODING encoding=STRING_LITERAL)? #primitiveDataType
```
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisLexer.g4:
##########
@@ -218,6 +218,7 @@ DYNAMIC: 'DYNAMIC';
E:'E';
ELSE: 'ELSE';
ENABLE: 'ENABLE';
+ENCODING: 'ENCODING';
Review Comment:
should be non-reserved keyword
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -2840,7 +2841,7 @@ public Expression visitConvertType(DorisParser.ConvertTypeContext ctx) {
public DataType visitCastDataType(CastDataTypeContext ctx) {
return ParserUtils.withOrigin(ctx, () -> {
if (ctx.dataType() != null) {
- return ((DataType) typedVisit(ctx.dataType())).conversion();
+ return ((TypeAndEncoding) typedVisit(ctx.dataType())).getDataType().conversion();
Review Comment:
CstDataType should not allow specific encoding
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -4298,19 +4299,21 @@ private ExplainLevel parseExplainPlanType(PlanTypeContext planTypeContext) {
}
@Override
- public Pair<DataType, Boolean> visitDataTypeWithNullable(DataTypeWithNullableContext ctx) {
+ public Pair<TypeAndEncoding, Boolean> visitDataTypeWithNullable(DataTypeWithNullableContext ctx) {
return ParserUtils.withOrigin(ctx, () -> Pair.of(typedVisit(ctx.dataType()), ctx.NOT() == null));
}
@Override
- public DataType visitAggStateDataType(AggStateDataTypeContext ctx) {
+ public TypeAndEncoding visitAggStateDataType(AggStateDataTypeContext ctx) {
return ParserUtils.withOrigin(ctx, () -> {
- List<Pair<DataType, Boolean>> dataTypeWithNullables = ctx.dataTypes.stream()
+ List<Pair<TypeAndEncoding, Boolean>> dataTypeWithNullables = ctx.dataTypes.stream()
Review Comment:
aggState dataType should not allow specific encoding
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/TypeAndEncoding.java:
##########
@@ -0,0 +1,243 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands.info;
+
+import org.apache.doris.catalog.EncodingInfo;
+import org.apache.doris.catalog.EncodingTree;
+import org.apache.doris.nereids.types.AggStateType;
+import org.apache.doris.nereids.types.ArrayType;
+import org.apache.doris.nereids.types.BigIntType;
+import org.apache.doris.nereids.types.BooleanType;
+import org.apache.doris.nereids.types.CharType;
+import org.apache.doris.nereids.types.DataType;
+import org.apache.doris.nereids.types.DateTimeType;
+import org.apache.doris.nereids.types.DateTimeV2Type;
+import org.apache.doris.nereids.types.DateType;
+import org.apache.doris.nereids.types.DateV2Type;
+import org.apache.doris.nereids.types.DecimalV2Type;
+import org.apache.doris.nereids.types.DecimalV3Type;
+import org.apache.doris.nereids.types.DoubleType;
+import org.apache.doris.nereids.types.FloatType;
+import org.apache.doris.nereids.types.HllType;
+import org.apache.doris.nereids.types.IPv4Type;
+import org.apache.doris.nereids.types.IPv6Type;
+import org.apache.doris.nereids.types.IntegerType;
+import org.apache.doris.nereids.types.JsonType;
+import org.apache.doris.nereids.types.LargeIntType;
+import org.apache.doris.nereids.types.MapType;
+import org.apache.doris.nereids.types.QuantileStateType;
+import org.apache.doris.nereids.types.SmallIntType;
+import org.apache.doris.nereids.types.StringType;
+import org.apache.doris.nereids.types.StructField;
+import org.apache.doris.nereids.types.StructType;
+import org.apache.doris.nereids.types.TinyIntType;
+import org.apache.doris.nereids.types.VarcharType;
+import org.apache.doris.nereids.types.VariantType;
+import org.apache.doris.nereids.types.coercion.ComplexDataType;
+import org.apache.doris.nereids.types.coercion.PrimitiveType;
+
+import com.google.common.base.Strings;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
+import doris.segment_v2.SegmentV2;
+import doris.segment_v2.SegmentV2.EncodingTypePB;
+
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+/**
+ * Used to store the type and encoding of a column.
+ */
+public class TypeAndEncoding {
Review Comment:
TypeWithEncoding is a better name?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -4525,11 +4551,13 @@ public Command visitCreateUserDefineFunction(CreateUserDefineFunctionContext ctx
} else {
functionArgTypesInfo = new FunctionArgTypesInfo(new ArrayList<>(), false);
}
- DataType returnType = typedVisit(ctx.returnType);
+ TypeAndEncoding returnTypeAndEncoding = typedVisit(ctx.returnType);
Review Comment:
udf should not allow to specific encoding
##########
fe/fe-common/src/main/java/org/apache/doris/catalog/EncodingTree.java:
##########
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.catalog;
+
+import lombok.Getter;
+
+import java.util.List;
+
+public class EncodingTree {
+ @Getter
+ private final int encodingNumber;
+ private final List<EncodingTree> children;
Review Comment:
why need a tree? if u want to support nested type. i think their item aready has encoding info?
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisLexer.g4:
##########
@@ -218,6 +218,7 @@ DYNAMIC: 'DYNAMIC';
E:'E';
ELSE: 'ELSE';
ENABLE: 'ENABLE';
+ENCODING: 'ENCODING';
Review Comment:
add to non reserved keywords list in DorisParser.g4
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/NereidsParser.java:
##########
@@ -315,7 +316,8 @@ private static boolean isSimpleIdentifier(String expression) {
}
public DataType parseDataType(String dataType) {
Review Comment:
should rename this function. and this function currently only use for parse datatype in table properties for sequence column. so i think it should not to be allowed to specific encoding too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875026325
<details>
<summary>TPC-H: <b>Total hot run time: 34028 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e3f8a24967f275ad7dd0da83ac2e6ee1490f8c96, data reload: false
------ Round 1 ----------------------------------
q1 26992 5126 5046 5046
q2 2100 277 181 181
q3 10641 1280 692 692
q4 10253 1028 521 521
q5 7885 2361 2413 2361
q6 182 164 130 130
q7 907 769 612 612
q8 9330 1325 1056 1056
q9 6913 5066 5105 5066
q10 6826 2322 1899 1899
q11 491 283 266 266
q12 343 355 218 218
q13 17784 3705 3081 3081
q14 248 234 229 229
q15 553 486 481 481
q16 431 448 377 377
q17 617 856 375 375
q18 7698 7285 7194 7194
q19 1903 955 563 563
q20 333 344 224 224
q21 3878 3328 2445 2445
q22 1032 1038 1011 1011
Total cold run time: 117340 ms
Total hot run time: 34028 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5210 5063 5128 5063
q2 244 333 228 228
q3 2195 2704 2287 2287
q4 1376 1848 1507 1507
q5 4527 4487 4398 4398
q6 216 169 126 126
q7 1981 1900 1732 1732
q8 2659 2616 2495 2495
q9 7209 7112 7260 7112
q10 3045 3212 2750 2750
q11 583 521 496 496
q12 668 746 622 622
q13 3557 3968 3304 3304
q14 301 293 289 289
q15 532 483 465 465
q16 442 496 439 439
q17 1170 1508 1406 1406
q18 7775 7481 7337 7337
q19 841 812 811 811
q20 2008 2010 1803 1803
q21 5124 4652 4597 4597
q22 1088 1028 960 960
Total cold run time: 52751 ms
Total hot run time: 50227 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50632:
URL: https://github.com/apache/doris/pull/50632#issuecomment-2875046086
<details>
<summary>ClickBench: <b>Total hot run time: 29.29 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e3f8a24967f275ad7dd0da83ac2e6ee1490f8c96, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.11 0.11
query3 0.25 0.19 0.19
query4 1.60 0.19 0.19
query5 0.60 0.59 0.62
query6 1.19 0.73 0.72
query7 0.02 0.02 0.02
query8 0.04 0.03 0.03
query9 0.57 0.51 0.54
query10 0.58 0.57 0.56
query11 0.17 0.12 0.11
query12 0.15 0.12 0.12
query13 0.62 0.60 0.60
query14 0.79 0.82 0.82
query15 0.88 0.85 0.86
query16 0.40 0.39 0.38
query17 1.05 1.08 1.05
query18 0.23 0.21 0.21
query19 2.00 1.81 1.84
query20 0.01 0.01 0.02
query21 15.44 0.92 0.53
query22 0.76 1.09 0.58
query23 15.15 1.37 0.65
query24 6.99 1.62 0.85
query25 0.46 0.14 0.07
query26 0.70 0.17 0.12
query27 0.06 0.05 0.05
query28 8.95 0.91 0.44
query29 12.57 4.04 3.34
query30 0.25 0.09 0.07
query31 2.83 0.62 0.39
query32 3.23 0.55 0.46
query33 3.06 3.06 3.09
query34 15.77 5.08 4.45
query35 4.56 4.56 4.52
query36 0.68 0.50 0.49
query37 0.09 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.03
query40 0.17 0.13 0.14
query41 0.08 0.03 0.02
query42 0.04 0.02 0.02
query43 0.04 0.03 0.02
Total cold run time: 103.27 s
Total hot run time: 29.29 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on code in PR #50632:
URL: https://github.com/apache/doris/pull/50632#discussion_r2165579958
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -2840,7 +2841,7 @@ public Expression visitConvertType(DorisParser.ConvertTypeContext ctx) {
public DataType visitCastDataType(CastDataTypeContext ctx) {
return ParserUtils.withOrigin(ctx, () -> {
if (ctx.dataType() != null) {
- return ((DataType) typedVisit(ctx.dataType())).conversion();
+ return ((TypeAndEncoding) typedVisit(ctx.dataType())).getDataType().conversion();
Review Comment:
Setting encoding in cast is an invalid operation. We can indicate this in document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](meta) Support specifying column encoding [doris]
Posted by "liutang123 (via GitHub)" <gi...@apache.org>.
liutang123 commented on code in PR #50632:
URL: https://github.com/apache/doris/pull/50632#discussion_r2165581248
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -4525,11 +4551,13 @@ public Command visitCreateUserDefineFunction(CreateUserDefineFunctionContext ctx
} else {
functionArgTypesInfo = new FunctionArgTypesInfo(new ArrayList<>(), false);
}
- DataType returnType = typedVisit(ctx.returnType);
+ TypeAndEncoding returnTypeAndEncoding = typedVisit(ctx.returnType);
Review Comment:
The same as CastDataType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org