[GitHub] [incubator-superset] serenajiang opened a new pull request #8220: [sqllab] use celery worker for stop_query

[GitBox <gi...@apache.org>]

serenajiang opened a new pull request #8220: [sqllab] use celery worker for stop_query
URL: https://github.com/apache/incubator-superset/pull/8220
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   #8139 introduced retries for `stop_query` because of lock timeout issues.
   
   This turned out to be problematic because users now have to wait a few seconds after clicking "stop_query" before receiving a message that stopping the query failed.
   
   So now, if a celery worker is available, we run stop_query on a celery worker so that users immediately get a response and don't have to wait for the query to stop. Doesn't actually fix the errors, but at least now users won't see them.
   
   ### TEST PLAN
   Checked whether `stop_query` worked as expected locally. Threw some fake exceptions to make sure retries still worked.
   
   Confirmed that `stop_query` works whether or not a celery worker is available.
   
   ### REVIEWERS
   @graceguo-supercat @etr2460 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org