You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/02/17 09:41:46 UTC

[GitHub] [trafficserver] maskit opened a new pull request #7531: Remove dependency for SSL stuff from P_Net.h

maskit opened a new pull request #7531:
URL: https://github.com/apache/trafficserver/pull/7531


   P_Net.h includes some header files for SSL stuff, but those headers doesn't have to be included in P_Net.h. I think we should not include those in P_Net.h because it's included by many places and a small change on one of those header files requires rebuilding many modules.
   
   The same approach is actually already done for QUIC stuff. As you can see, P_Net.h does not include P_QUICNetVConnection.h.
   
   There are some sad cases (e.g. Http1ClientSession.cc  includes P_SSLNetVConnection.h), but those have been implicitly included for long time. I think I can cleanup those places on another PR.
   
   Files that require P_Net.h:
   ```
   $ git grep "P_Net.h" | grep -v "\.cc"
   include/ts/InkAPIPrivateIOCore.h:#include "P_Net.h"
   iocore/cache/test/main.h:#include "P_Net.h"
   iocore/dns/P_DNS.h:#include "P_Net.h"
   iocore/net/Makefile.am:	P_Net.h \
   iocore/net/P_QUICNet.h:#include "P_Net.h"
   iocore/net/P_QUICNetProcessor.h:#include "P_Net.h"
   iocore/net/P_QUICNetVConnection.h:#include "P_Net.h"
   iocore/net/P_SSLNetProcessor.h:#include "P_Net.h"
   iocore/net/P_SSLNextProtocolAccept.h:#include "P_Net.h"
   iocore/net/P_UnixNet.h:#include "P_Net.h"
   iocore/net/quic/Mock.h:#include "P_Net.h"
   proxy/InkAPIInternal.h:#include "P_Net.h"
   proxy/PluginVC.h:#include "P_Net.h"
   proxy/ProxySession.h:#include "P_Net.h"
   proxy/http/Http1ClientSession.h:#include "P_Net.h"
   proxy/http/Http1ServerSession.h:#include "P_Net.h"
   proxy/http/HttpTransact.h:#include "P_Net.h"
   proxy/http2/Http2Frame.h:#include "P_Net.h"
   src/traffic_quic/quic_client.h:#include "P_Net.h"
   src/traffic_server/FetchSM.h:#include "P_Net.h"
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit merged pull request #7531: Remove dependency for SSL stuff from P_Net.h

Posted by GitBox <gi...@apache.org>.
maskit merged pull request #7531:
URL: https://github.com/apache/trafficserver/pull/7531


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org