svn commit: r1821747 - in /jmeter/trunk: src/core/org/apache/jmeter/functions/gui/FunctionHelper.java xdocs/changes.xml

[pm...@apache.org]

Author: pmouawad
Date: Sat Jan 20 14:54:54 2018
New Revision: 1821747

URL: http://svn.apache.org/viewvc?rev=1821747&view=rev
Log:
Bug 62027 - Function Helper Dialog : Make Help button open browser on function documentation instead of Internal Dialog
Bugzilla Id: 62027

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java?rev=1821747&r1=1821746&r2=1821747&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java Sat Jan 20 14:54:54 2018
@@ -45,8 +45,8 @@ import org.apache.jmeter.config.gui.Argu
 import org.apache.jmeter.engine.ClientJMeterEngine;
 import org.apache.jmeter.engine.util.CompoundVariable;
 import org.apache.jmeter.functions.Function;
+import org.apache.jmeter.gui.action.ActionNames;
 import org.apache.jmeter.gui.action.ActionRouter;
-import org.apache.jmeter.gui.action.Help;
 import org.apache.jmeter.gui.action.KeyStrokes;
 import org.apache.jmeter.gui.util.JSyntaxTextArea;
 import org.apache.jmeter.gui.util.JTextScrollPane;
@@ -208,9 +208,10 @@ public class FunctionHelper extends JDia
     private class HelpListener implements ActionListener {
         @Override
         public void actionPerformed(ActionEvent e) {
-            String[] source = new String[] { Help.HELP_FUNCTIONS, functionList.getText() };
-            ActionEvent helpEvent = new ActionEvent(source, e.getID(), "help"); //$NON-NLS-1$
-            ActionRouter.getInstance().actionPerformed(helpEvent);
+            String source = functionList.getText();
+            ActionRouter.getInstance().doActionNow(
+                    new ActionEvent(source, e.getID(), ActionNames.LINK_FUNC_REF));
+
         }
     }
 

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1821747&r1=1821746&r2=1821747&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Jan 20 14:54:54 2018
@@ -208,6 +208,7 @@ Graphs <i>Latency Vs Request</i> and <i>
     <li><bug>61759</bug>Add <code>__changeCase</code> function to change different cases of a string. Based on a contribution by orimarko at gmail.com</li>
     <li><bug>61561</bug>Function helper dialog should display exception in result</li>
     <li><bug>61738</bug>Function Helper Dialog: Add Copy in Generate and clarify labels. Contributed by Ubik Load Pack (support at ubikloadpack.com)</li>
+    <li><bug>62027</bug>Function Helper Dialog : Make Help button open browser on function documentation instead of Internal Dialog</li>
     <li><bug>61593</bug>Remove Detail, Add, Add from Clipboard, Delete buttons in Function Helper GUI</li>
 </ul>