[GitHub] [zookeeper] ctubbsii commented on issue #1268: ZOOKEEPER-3738: Use mavanagaiata for git commit id

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #1268: ZOOKEEPER-3738: Use mavanagaiata for git commit id
URL: https://github.com/apache/zookeeper/pull/1268#issuecomment-591078818
 
 
   > We should also drop VerGen stuff and simply use maven filtering to create a properties file to be read from class path at runtime.
   
   I was also taking a look at the VerGen class and thinking about improving it a bit. I think it's useful to have hard-coded class, rather than read from class path... because class path pollution can mislead the code logic.
   
   So, instead, I suggest doing what I did a very long time ago for Accumulo, and use mvn resource filtering to inject the version information from the POM into the java code, and then use the build-helper-maven-plugin to put that generated code onto the compile-time class path. It's serves a similar purpose as the current VerGen stuff, but I think the implementation is a bit nicer (certainly smaller):
   
   https://github.com/apache/accumulo/blob/master/core/pom.xml#L266-L305

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services