You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/12 08:00:09 UTC

[GitHub] [apisix-dashboard] gymgym1212 opened a new pull request, #2451: docs: update some tips in develop.md

gymgym1212 opened a new pull request, #2451:
URL: https://github.com/apache/apisix-dashboard/pull/2451

   Signed-off-by: Yeming Gu <ye...@gmail.com>
   
   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [X] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Add some tips into `develop.md` to improve comprehensibility.
   
   - advise to change the `make-api` address explicitly. Otherwise, an `403 forbidden` error will be generated when logging in, because the API address cannot be found.
   - prompt the user to ignore gyp errors during `yarn install`
   
   **Related issues**
   
   fix/resolve #2427 
   
   **Checklist:**
   
   - [X] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [X] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gymgym1212 commented on pull request #2451: docs: update some tips in develop.md

Posted by GitBox <gi...@apache.org>.
gymgym1212 commented on PR #2451:
URL: https://github.com/apache/apisix-dashboard/pull/2451#issuecomment-1133655406

   > "First-time contributors need a maintainer to approve running workflows."
   
   Hi @juzhiyuan , can you approve these workflows?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gymgym1212 commented on pull request #2451: docs: update some tips in develop.md

Posted by GitBox <gi...@apache.org>.
gymgym1212 commented on PR #2451:
URL: https://github.com/apache/apisix-dashboard/pull/2451#issuecomment-1133600634

   > LGTM, and @gymgym1212 pls fix the ci, it failed
   
   Got it. I will fix the ci.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gymgym1212 commented on pull request #2451: docs: update some tips in develop.md

Posted by GitBox <gi...@apache.org>.
gymgym1212 commented on PR #2451:
URL: https://github.com/apache/apisix-dashboard/pull/2451#issuecomment-1133655281

   "First-time contributors need a maintainer to approve running workflows."


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop merged pull request #2451: docs: update some tips in develop.md

Posted by GitBox <gi...@apache.org>.
Baoyuantop merged PR #2451:
URL: https://github.com/apache/apisix-dashboard/pull/2451


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org