You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/12/03 01:50:11 UTC
[GitHub] [ozone] aswinshakil commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
aswinshakil commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038661475
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -218,37 +223,47 @@ public class TestNSSummaryEndpointWithFSO {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
= CONTAINER_FOUR_REPLICA_COUNT * BLOCK_FOUR_LENGTH
+ CONTAINER_FIVE_REPLICA_COUNT * BLOCK_FIVE_LENGTH
+ CONTAINER_SIX_REPLICA_COUNT * BLOCK_SIX_LENGTH;
private static final long FILE1_SIZE_WITH_REPLICA =
- LOCATION_INFO_GROUP_ONE_SIZE;
+ getReplicatedSize(KEY_ONE_SIZE,
Review Comment:
Are we only considering file size with single replica?
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -218,37 +223,47 @@ public class TestNSSummaryEndpointWithFSO {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
Review Comment:
If this is no longer being referenced, Can we remove it? Same for `LOCATION_INFO_GROUP_ONE_SIZE`
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java:
##########
@@ -222,37 +227,48 @@ public class TestNSSummaryEndpointWithLegacy {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
Review Comment:
Same as the above comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org