You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/22 15:42:35 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #4327: fix bug: right semi join can't support the filter

Dandandan commented on code in PR #4327:
URL: https://github.com/apache/arrow-datafusion/pull/4327#discussion_r1029501621


##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -852,6 +852,7 @@ fn build_join_indexes(
                             &keys_values,
                             *null_equals_null,
                         )? {
+                            left_indices.append(i);

Review Comment:
   Ah good find. I missed the case where this would be used.
   Thanks for adding the unit test!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org