You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "contextshuffling (Jira)" <ji...@apache.org> on 2019/10/05 20:48:00 UTC
[jira] [Updated] (CALCITE-3389) Test can fail if HashSet iterates
in a different order
[ https://issues.apache.org/jira/browse/CALCITE-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
contextshuffling updated CALCITE-3389:
--------------------------------------
Description:
For test `testTenElementsSetLiteral`([https://github.com/apache/calcite/blob/78c2a007b5b597f673323b80dde21c23d31f23ea/linq4j/src/test/java/org/apache/calcite/linq4j/test/ExpressionTest.java#L1538) |https://github.com/apache/calcite/blob/78c2a007b5b597f673323b80dde21c23d31f23ea/linq4j/src/test/java/org/apache/calcite/linq4j/test/ExpressionTest.java#L1538)]
It relies on the iteration order of a HashSet. However, HashSet does not guarantee any specific order of entries. Tests can fail if the iteration order changes.
Please let me know if you want to discuss the changes more.
was:
For test `testTenElementsSetLiteral`([https://github.com/apache/calcite/blob/78c2a007b5b597f673323b80dde21c23d31f23ea/linq4j/src/test/java/org/apache/calcite/linq4j/test/ExpressionTest.java#L1538) |https://github.com/apache/calcite/blob/78c2a007b5b597f673323b80dde21c23d31f23ea/linq4j/src/test/java/org/apache/calcite/linq4j/test/ExpressionTest.java#L1538)]it relies on the iteration order of a HashSet. However, HashSet does not guarantee any specific order of entries. Tests can fail if the order changes.
Please let me know if you want to discuss the changes more.
> Test can fail if HashSet iterates in a different order
> ------------------------------------------------------
>
> Key: CALCITE-3389
> URL: https://issues.apache.org/jira/browse/CALCITE-3389
> Project: Calcite
> Issue Type: Bug
> Reporter: contextshuffling
> Priority: Minor
>
> For test `testTenElementsSetLiteral`([https://github.com/apache/calcite/blob/78c2a007b5b597f673323b80dde21c23d31f23ea/linq4j/src/test/java/org/apache/calcite/linq4j/test/ExpressionTest.java#L1538) |https://github.com/apache/calcite/blob/78c2a007b5b597f673323b80dde21c23d31f23ea/linq4j/src/test/java/org/apache/calcite/linq4j/test/ExpressionTest.java#L1538)]
> It relies on the iteration order of a HashSet. However, HashSet does not guarantee any specific order of entries. Tests can fail if the iteration order changes.
> Please let me know if you want to discuss the changes more.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)