You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/20 13:26:10 UTC

[GitHub] [flink] pnowojski commented on pull request #13667: [FLINK-19679] Deduplicate code between CheckpointBarrierUnaligner and CheckpointBarrierAligner

pnowojski commented on pull request #13667:
URL: https://github.com/apache/flink/pull/13667#issuecomment-712848488


   Thanks for the review.
   
   No I haven't but none of the changes are on any of the critical code paths (per record, or even per buffer). It only affects per checkpoint, and the difference is tiny (one additional "bimorphic" virtual call), so I wouldn't worry about performance impact.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org