[GitHub] [cloudstack] RodrigoDLopez commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR

[GitBox <gi...@apache.org>]

RodrigoDLopez commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r935886240


##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,6 +2126,11 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
             }
         }
 
+        String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+        s_logger.debug(String.format("The setting [%s] with value [%s] for the zone with UUID [%s], will be used to configure the logrotate service frequency" +
+                        " on the virtual router.", RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
+        buf.append(String.format(" logrotatefrequency=%s", routerLogrotateFrequency));

Review Comment:
   I did not test with nonsense values, just the value of `null`, in this case, the default value will be applied and some values that make any sense, so I am not sure if a nonsense value will break logrotate service.
   any suggestion to ensure that the operators will follow the pattern?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org