You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ossie.apache.org by "Copilot (via GitHub)" <gi...@apache.org> on 2026/10/02 06:47:05 UTC

Re: [PR] feat(python models): Add version support for python models [ossie]

Copilot commented on code in PR #195:
URL: https://github.com/apache/ossie/pull/195#discussion_r4163461780


##########
python/src/ossie/__init__.py:
##########
@@ -15,6 +15,13 @@
 # specific language governing permissions and limitations
 # under the License.
 
+from importlib.metadata import version, PackageNotFoundError
+
+try:
+    __version__ = version("apache-ossie")
+except PackageNotFoundError:
+    __version__ = "unknown"

Review Comment:
   This new public version contract is not covered by the Python test suite. Please add a packaging test that verifies `ossie.__version__` matches `importlib.metadata.version("apache-ossie")`, and cover the `PackageNotFoundError` fallback so regressions in either path are detected; the repository already tests the analogous contract in `converters/thoughtspot/tests/test_packaging.py:27-28`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org