[GitHub] [datasketches-cpp] jmalkin commented on a diff in pull request #350: HLL minor cleanup and slight performance improvement

["jmalkin (via GitHub)" <gi...@apache.org>]

jmalkin commented on code in PR #350:
URL: https://github.com/apache/datasketches-cpp/pull/350#discussion_r1129930417


##########
hll/include/HllArray-internal.hpp:
##########
@@ -434,16 +434,6 @@ void HllArray<A>::putNumAtCurMin(uint32_t numAtCurMin) {
   numAtCurMin_ = numAtCurMin;
 }
 
-template<typename A>
-void HllArray<A>::decNumAtCurMin() {
-  --numAtCurMin_;
-}
-
-template<typename A>
-void HllArray<A>::addToHipAccum(double delta) {

Review Comment:
   Apparently this was never even used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org