You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by jd...@apache.org on 2005/09/15 21:11:21 UTC
svn commit: r289290 - /maven/components/trunk/maven-core-it/it0063/pom.xml
Author: jdcasey
Date: Thu Sep 15 12:11:16 2005
New Revision: 289290
URL: http://svn.apache.org/viewcvs?rev=289290&view=rev
Log:
Trying to adjust to work with OSX.
Modified:
maven/components/trunk/maven-core-it/it0063/pom.xml
Modified: maven/components/trunk/maven-core-it/it0063/pom.xml
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-core-it/it0063/pom.xml?rev=289290&r1=289289&r2=289290&view=diff
==============================================================================
--- maven/components/trunk/maven-core-it/it0063/pom.xml (original)
+++ maven/components/trunk/maven-core-it/it0063/pom.xml Thu Sep 15 12:11:16 2005
@@ -10,7 +10,7 @@
<artifactId>jdk-tools</artifactId>
<version>1.4.2</version>
<scope>system</scope>
- <systemPath>${java.home}/../lib/tools.jar</systemPath>
+ <systemPath>${toolsJarPath}</systemPath>
</dependency>
<dependency>
<groupId>junit</groupId>
@@ -19,4 +19,30 @@
<scope>test</scope>
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <id>default-tools.jar</id>
+ <activation>
+ <property>
+ <name>java.vendor</name>
+ <value>Sun Microsystems Inc.</value>
+ </property>
+ </activation>
+ <properties>
+ <toolsJarPath>${java.home}/../lib/tools.jar</toolsJarPath>
+ </properties>
+ </profile>
+ <profile>
+ <id>osx-tools.jar</id>
+ <activation>
+ <property>
+ <name>java.vendor</name>
+ <value>Apple Computer, Inc.</value>
+ </property>
+ </activation>
+ <properties>
+ <toolsJarPath>${java.home}/../Classes/classes.jar</toolsJarPath>
+ </properties>
+ </profile>
+ </profiles>
</model>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r289290 - /maven/components/trunk/maven-core-it/it0063/pom.xml
Posted by John Casey <jd...@commonjava.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I agree, but we may not be able to define a workable tools.jar
reference...as noted in the OSX discussion on users@. In this case, I
suppose it'll just have to be broken...
thoughts?
- -john
Brett Porter wrote:
| I'm just thinking, in the case of tools.jar, that a prepopulated
| variable/expression might be appropriate rather than requiring each user
| to have to specify this profile. And if the built in version doesn't
| suffice for platform X running DontCallMeJavaVM, they can always use the
| profile.
|
| What do you think?
|
| - Brett
|
| John Casey wrote:
|
|
|>Build it in how? Anything having to do with system paths is going to be
|>really fragile, we knew that. But, it's also what profiles were designed
|>to do...the only problem is in detecting the specific JVM (rather than
|>just the OS). I agree that it seems a little complex, but the concept of
|>system scoped dependencies inherently means you have to be *very*
|>careful to handle multiple environments.
|>
|>If you have any ideas on how to make this cleaner, I'd be eager to
|>discuss it.
|>
|>-john
|
|
|
| ---------------------------------------------------------------------
| To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
| For additional commands, e-mail: dev-help@maven.apache.org
|
|
|
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFDKu/VK3h2CZwO/4URAoppAJ46uIgnq/az4xArsM2Ckbj4GBAJFACgkUHP
m0DbdBDwqXrh8ExatlG1GTc=
=a2u5
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r289290 - /maven/components/trunk/maven-core-it/it0063/pom.xml
Posted by Brett Porter <br...@apache.org>.
I'm just thinking, in the case of tools.jar, that a prepopulated
variable/expression might be appropriate rather than requiring each user
to have to specify this profile. And if the built in version doesn't
suffice for platform X running DontCallMeJavaVM, they can always use the
profile.
What do you think?
- Brett
John Casey wrote:
> Build it in how? Anything having to do with system paths is going to be
> really fragile, we knew that. But, it's also what profiles were designed
> to do...the only problem is in detecting the specific JVM (rather than
> just the OS). I agree that it seems a little complex, but the concept of
> system scoped dependencies inherently means you have to be *very*
> careful to handle multiple environments.
>
> If you have any ideas on how to make this cleaner, I'd be eager to
> discuss it.
>
> -john
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r289290 - /maven/components/trunk/maven-core-it/it0063/pom.xml
Posted by John Casey <jd...@commonjava.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Build it in how? Anything having to do with system paths is going to be
really fragile, we knew that. But, it's also what profiles were designed
to do...the only problem is in detecting the specific JVM (rather than
just the OS). I agree that it seems a little complex, but the concept of
system scoped dependencies inherently means you have to be *very*
careful to handle multiple environments.
If you have any ideas on how to make this cleaner, I'd be eager to
discuss it.
- -john
Brett Porter wrote:
| Can we file an issue to build some of this in, please? I don't think we
| want everyone having to reproduce this one :)
|
| - Brett
|
| jdcasey@apache.org wrote:
|
|
|>Author: jdcasey
|>Date: Thu Sep 15 12:11:16 2005
|>New Revision: 289290
|>
|>URL: http://svn.apache.org/viewcvs?rev=289290&view=rev
|>Log:
|>Trying to adjust to work with OSX.
|>
|>Modified:
|> maven/components/trunk/maven-core-it/it0063/pom.xml
|>
|>Modified: maven/components/trunk/maven-core-it/it0063/pom.xml
|>URL:
http://svn.apache.org/viewcvs/maven/components/trunk/maven-core-it/it0063/pom.xml?rev=289290&r1=289289&r2=289290&view=diff
|>==============================================================================
|>--- maven/components/trunk/maven-core-it/it0063/pom.xml (original)
|>+++ maven/components/trunk/maven-core-it/it0063/pom.xml Thu Sep 15
12:11:16 2005
|>@@ -10,7 +10,7 @@
|> <artifactId>jdk-tools</artifactId>
|> <version>1.4.2</version>
|> <scope>system</scope>
|>- <systemPath>${java.home}/../lib/tools.jar</systemPath>
|>+ <systemPath>${toolsJarPath}</systemPath>
|> </dependency>
|> <dependency>
|> <groupId>junit</groupId>
|>@@ -19,4 +19,30 @@
|> <scope>test</scope>
|> </dependency>
|> </dependencies>
|>+ <profiles>
|>+ <profile>
|>+ <id>default-tools.jar</id>
|>+ <activation>
|>+ <property>
|>+ <name>java.vendor</name>
|>+ <value>Sun Microsystems Inc.</value>
|>+ </property>
|>+ </activation>
|>+ <properties>
|>+ <toolsJarPath>${java.home}/../lib/tools.jar</toolsJarPath>
|>+ </properties>
|>+ </profile>
|>+ <profile>
|>+ <id>osx-tools.jar</id>
|>+ <activation>
|>+ <property>
|>+ <name>java.vendor</name>
|>+ <value>Apple Computer, Inc.</value>
|>+ </property>
|>+ </activation>
|>+ <properties>
|>+ <toolsJarPath>${java.home}/../Classes/classes.jar</toolsJarPath>
|>+ </properties>
|>+ </profile>
|>+ </profiles>
|></model>
|>
|>
|>
|>---------------------------------------------------------------------
|>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
|>For additional commands, e-mail: dev-help@maven.apache.org
|>
|>
|>
|
|
| ---------------------------------------------------------------------
| To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
| For additional commands, e-mail: dev-help@maven.apache.org
|
|
|
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFDKiS3K3h2CZwO/4URAn0HAJ9XtUaAfvw3iD1Se09kA6Tl30ywmACgsAF0
JqRUSFLaM6qH2oNq4QRG4Ks=
=VRn3
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r289290 - /maven/components/trunk/maven-core-it/it0063/pom.xml
Posted by Brett Porter <br...@apache.org>.
Can we file an issue to build some of this in, please? I don't think we
want everyone having to reproduce this one :)
- Brett
jdcasey@apache.org wrote:
>Author: jdcasey
>Date: Thu Sep 15 12:11:16 2005
>New Revision: 289290
>
>URL: http://svn.apache.org/viewcvs?rev=289290&view=rev
>Log:
>Trying to adjust to work with OSX.
>
>Modified:
> maven/components/trunk/maven-core-it/it0063/pom.xml
>
>Modified: maven/components/trunk/maven-core-it/it0063/pom.xml
>URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-core-it/it0063/pom.xml?rev=289290&r1=289289&r2=289290&view=diff
>==============================================================================
>--- maven/components/trunk/maven-core-it/it0063/pom.xml (original)
>+++ maven/components/trunk/maven-core-it/it0063/pom.xml Thu Sep 15 12:11:16 2005
>@@ -10,7 +10,7 @@
> <artifactId>jdk-tools</artifactId>
> <version>1.4.2</version>
> <scope>system</scope>
>- <systemPath>${java.home}/../lib/tools.jar</systemPath>
>+ <systemPath>${toolsJarPath}</systemPath>
> </dependency>
> <dependency>
> <groupId>junit</groupId>
>@@ -19,4 +19,30 @@
> <scope>test</scope>
> </dependency>
> </dependencies>
>+ <profiles>
>+ <profile>
>+ <id>default-tools.jar</id>
>+ <activation>
>+ <property>
>+ <name>java.vendor</name>
>+ <value>Sun Microsystems Inc.</value>
>+ </property>
>+ </activation>
>+ <properties>
>+ <toolsJarPath>${java.home}/../lib/tools.jar</toolsJarPath>
>+ </properties>
>+ </profile>
>+ <profile>
>+ <id>osx-tools.jar</id>
>+ <activation>
>+ <property>
>+ <name>java.vendor</name>
>+ <value>Apple Computer, Inc.</value>
>+ </property>
>+ </activation>
>+ <properties>
>+ <toolsJarPath>${java.home}/../Classes/classes.jar</toolsJarPath>
>+ </properties>
>+ </profile>
>+ </profiles>
> </model>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org