You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@plc4x.apache.org by "Alvaro del Castillo (Jira)" <ji...@apache.org> on 2019/12/12 07:11:00 UTC

[jira] [Commented] (PLC4X-45) [Modbus] Make the modbus driver support reading and writing of all or at least most plc4x datatypes

    [ https://issues.apache.org/jira/browse/PLC4X-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994304#comment-16994304 ] 

Alvaro del Castillo commented on PLC4X-45:
------------------------------------------

It also support LONG. According to the comments of the driver inside the code:

https://github.com/apache/plc4x/blob/develop/plc4j/protocols/modbus/src/main/java/org/apache/plc4x/java/modbus/messages/items/DefaultModbusByteArrayFieldItem.java#L215

{noformat}
    //ToDo: Implement conversion for Float and Unsigned-Datatypes

    //ToDo: Add exceptions to avoid unwanted states --> e.g. neg indexes
{noformat}

In our modbus plugin we have implemented unsigned types (except float) and also signed float. My plan is to send PRs with the code.

The first one will be for float support.




> [Modbus] Make the modbus driver support reading and writing of all or at least most plc4x datatypes
> ---------------------------------------------------------------------------------------------------
>
>                 Key: PLC4X-45
>                 URL: https://issues.apache.org/jira/browse/PLC4X-45
>             Project: Apache PLC4X
>          Issue Type: Improvement
>          Components: Driver-Modbus
>            Reporter: Christofer Dutz
>            Priority: Major
>
> Currently it seems as if the Modbus driver only supports reading BOOLEAN, INT, SHORT and BYTE ... however we need to make it possible to also support others as the developer might combine neighboring fields.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)