You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Emil Anca <ea...@hortonworks.com> on 2015/05/18 15:59:17 UTC
Review Request 34352: Make Kafka Metrics Reporter agnostic to the
metrics names size
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34352/
-----------------------------------------------------------
Review request for Ambari, Costel Radulescu, Florian Barca, and Sid Wagle.
Bugs: AMBARI-11211
https://issues.apache.org/jira/browse/AMBARI-11211
Repository: ambari
Description
-------
Problem: Processing histograms and timers has hardcoded number of expected metric names
Solution: Replaced with array union via apache-commons
Diffs
-----
ambari-metrics/ambari-metrics-kafka-sink/pom.xml a4361b0
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 00a58ee
Diff: https://reviews.apache.org/r/34352/diff/
Testing
-------
Thanks,
Emil Anca
Re: Review Request 34352: Make Kafka Metrics Reporter agnostic to the
metrics names size
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34352/#review84149
-----------------------------------------------------------
Ship it!
Ship It!
- Florian Barca
On May 18, 2015, 1:59 p.m., Emil Anca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34352/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 1:59 p.m.)
>
>
> Review request for Ambari, Costel Radulescu, Florian Barca, and Sid Wagle.
>
>
> Bugs: AMBARI-11211
> https://issues.apache.org/jira/browse/AMBARI-11211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem: Processing histograms and timers has hardcoded number of expected metric names
> Solution: Replaced with array union via apache-commons
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-kafka-sink/pom.xml a4361b0
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 00a58ee
>
> Diff: https://reviews.apache.org/r/34352/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Emil Anca
>
>
Re: Review Request 34352: Make Kafka Metrics Reporter agnostic to the
metrics names size
Posted by Emil Anca <ea...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34352/
-----------------------------------------------------------
(Updated May 18, 2015, 1:59 p.m.)
Review request for Ambari, Costel Radulescu, Florian Barca, and Sid Wagle.
Bugs: AMBARI-11211
https://issues.apache.org/jira/browse/AMBARI-11211
Repository: ambari
Description
-------
Problem: Processing histograms and timers has hardcoded number of expected metric names
Solution: Replaced with array union via apache-commons
Diffs
-----
ambari-metrics/ambari-metrics-kafka-sink/pom.xml a4361b0
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 00a58ee
Diff: https://reviews.apache.org/r/34352/diff/
Testing (updated)
-------
mvn clean test
Thanks,
Emil Anca