[GitHub] [dubbo-go] AlexStocks commented on pull request #1189: reuse MockEventDispatcher and NewMockServiceNameMapping in service discovery test

[GitBox <gi...@apache.org>]

AlexStocks commented on pull request #1189:
URL: https://github.com/apache/dubbo-go/pull/1189#issuecomment-840615432


   @gaoxinge , pls check the following files
   
   ```go
   ./common/extension/event_dispatcher.go:56:			"like import _ github.com/apache/dubbo-go/common/observer/dispatcher ")
   ./common/extension/registry.go:35:		panic("registry for " + name + " does not exist. please make sure that you have imported the package `github.com/apache/dubbo-go/registry/" + name + "`.")
   ./common/extension/metadata_remote.go:49:		"remote - github.com/apache/dubbo-go/metadata/remote/impl"))
   ./common/extension/metadata_service_proxy_factory.go:48:		"local - github.com/apache/dubbo-go/metadata/service/inmemory, \n", name))
   ./common/extension/metadata_service.go:53:		"local - github.com/apache/dubbo-go/metadata/service/inmemory, "))
   ./contributing.md:62:  "github.com/apache/dubbo-go/common"
   ./protocol/dubbo3/protoc-gen-dubbo3/go.mod:1:module github.com/apache/dubbo-go/protocol/dubbo3/protoc-gen-dubbo3
   ./protocol/dubbo3/protoc-gen-dubbo3/main.go:32:	_ "github.com/apache/dubbo-go/protocol/dubbo3/protoc-gen-dubbo3/plugin/dubbo3"
   ./protocol/invoker.go:44://go:generate mockgen -source invoker.go -destination mock/mock_invoker.go  -self_package github.com/apache/dubbo-go/protocol/mock --package mock  Invoker
   ./test/integrate/dubbo/go-client/go.mod:1:module github.com/apache/dubbo-go/test/integrate/dubbo/go-client
   ./test/integrate/dubbo/go-server/go.mod:1:module github.com/apache/dubbo-go/test/integrate/dubbo/go-server
   ./test/integrate/dubbo/go-server/go.mod:9:	// RUN test ${PR_ORIGIN_REPO} && go mod edit -replace=dubbo.apache.org/dubbo-go/v3=github.com/${PR_ORIGIN_REPO}@${PR_ORIGIN_COMMITID} || go get -u dubbo.apache.org/dubbo-go/v3@develop
   ./tools/cli/go.mod:1:module github.com/apache/dubbo-go/tools/cli
   ./tools/cli/example/server/go.sum:117:github.com/apache/dubbo-go v1.5.1 h1:9bcGOkek0+x+zqtvykKpuOwkoJfMef0zNxsyPbWOafY=
   ./tools/cli/example/server/go.sum:118:github.com/apache/dubbo-go v1.5.1/go.mod h1:lxwgtF+27mSFQsSrBLaVbdQpwCp+pBN/mHP4w4/N2Qc=
   ./tools/cli/example/server/go.sum:119:github.com/apache/dubbo-go v1.5.4 h1:kRVw2p6Fqk5PlJGHeb8IVFg5AuBJFPFvCvRm7/i3Qco=
   ./tools/cli/example/server/go.sum:120:github.com/apache/dubbo-go v1.5.4/go.mod h1:QIqjEvIbgmuk1mESsQSsTsFngHlYLGAmRN9gXN+YJq4=
   ./tools/cli/protocol/dubbo/dubbo_protocol.go:33:	"github.com/apache/dubbo-go/tools/cli/common"
   ./tools/cli/protocol/dubbo/dubbo_protocol.go:34:	"github.com/apache/dubbo-go/tools/cli/protocol"
   ./tools/cli/common/protocol.go:21:	"github.com/apache/dubbo-go/tools/cli/protocol"
   ./tools/cli/json_register/json_register.go:32:	"github.com/apache/dubbo-go/tools/cli/common"
   ./tools/cli/client/client.go:33:	"github.com/apache/dubbo-go/tools/cli/common"
   ./tools/cli/client/client.go:34:	"github.com/apache/dubbo-go/tools/cli/protocol"
   ./tools/cli/client/client.go:35:	_ "github.com/apache/dubbo-go/tools/cli/protocol/dubbo"
   ./tools/cli/main.go:26:	"github.com/apache/dubbo-go/tools/cli/client"
   ./tools/cli/main.go:27:	"github.com/apache/dubbo-go/tools/cli/json_register"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org