You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/04 14:45:10 UTC
[GitHub] [superset] wiktor2200 opened a new pull request, #20973: feat(helm): add custom images for different pods
wiktor2200 opened a new pull request, #20973:
URL: https://github.com/apache/superset/pull/20973
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I've added support for different docker images for different pods. It's extremely useful when using custom build images (such as worker with webdriver and the rest without).
Image still can be defined globally (as earlier) or specific for every pod in `values` file.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue: No, since feature request are moved to Discussions section.
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #20973: feat(helm): add custom images for different pods
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #20973:
URL: https://github.com/apache/superset/pull/20973#issuecomment-1208329572
Which perms are needed? We're using webdriver as well (for thumbnail generation) and haven't had any issues in terms of permissions. Everything works fine using uid `1000`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #20973: feat(helm): add custom images for different pods
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on PR #20973:
URL: https://github.com/apache/superset/pull/20973#issuecomment-1208530983
Sorry for my mental shortcut. When it's pre-prepared (webdriver added to docker image) it can be run as `1000`, but I wanted to run the rest with lighter image, so I've tried to use lighter and then installing webdriver (which was only possible as root). This is how I came up with an idea to add different images to different pods.
Anyway if you think that it's not a good idea (and practice) to add this code I'm closing this PR and maybe it would be solved some other way in the future. And thanks for your feedback :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #20973: feat(helm): add custom images for different pods
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on PR #20973:
URL: https://github.com/apache/superset/pull/20973#issuecomment-1205470096
That's also why I've not set it as required in json schema. So there is possibility to use it, but by default it's commented out in values.yaml and `if` clause checking which value to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #20973: feat(helm): add custom images for different pods
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on PR #20973:
URL: https://github.com/apache/superset/pull/20973#issuecomment-1206326467
@craig-rueda Do you have any suggestions how can I solve it other way and still being able to give different images to at least Superset worker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #20973: feat(helm): add custom images for different pods
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #20973:
URL: https://github.com/apache/superset/pull/20973#issuecomment-1205458904
Thanks for your contribution! I think this makes the config slightly harder to maintain, however :(. What's preventing you from just adding the `webdriver` to the "custom" image you're using and then reusing it across all pods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #20973: feat(helm): add custom images for different pods
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on PR #20973:
URL: https://github.com/apache/superset/pull/20973#issuecomment-1205465852
Webdriver (chrome) for Alerts & Report feature unfortunately needs higher permissions to run, otherwise it cannot took screenshots. I wanted to run whole superset as user 1000, so I thought running it in worker is required, but others are using official apache/superset in my case.
What is more using lighter image (without webdriver) for init, celery, supersetnode makes it faster. (smaller the better)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #20973: feat(helm): add custom images for different pods
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on PR #20973:
URL: https://github.com/apache/superset/pull/20973#issuecomment-1205358343
@craig-rueda please take a look and review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 closed pull request #20973: feat(helm): add custom images for different pods
Posted by GitBox <gi...@apache.org>.
wiktor2200 closed pull request #20973: feat(helm): add custom images for different pods
URL: https://github.com/apache/superset/pull/20973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org