You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/28 08:35:24 UTC
[GitHub] [iotdb] HeimingZ opened a new pull request #3642: [IOTDB-1531] Check tsfile time when recovering
HeimingZ opened a new pull request #3642:
URL: https://github.com/apache/iotdb/pull/3642
Check tsfile's time when recovering, make sure all tsfile time are less than System.currentTimeMillis(). If the tsfile's time is larger than System.currentTimeMillis(), the recover of corresponding virtual storage group will fail, users cannot read/write this virtual storage group until the time of the tsfile is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3642: [IOTDB-1531] Check tsfile time when recovering
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3642:
URL: https://github.com/apache/iotdb/pull/3642#issuecomment-888779403
[](https://coveralls.io/builds/41737905)
Coverage decreased (-0.007%) to 68.217% when pulling **bccd936c0066acafde90c0fd9952dde99ff42165 on HeimingZ:IOTDB-1531(check_tsfile_time_when_recovering)** into **0b2d0af48e00b6b72c5e4625e3a9613ac1c6204d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #3642: [IOTDB-1531] Check tsfile time when recovering
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on pull request #3642:
URL: https://github.com/apache/iotdb/pull/3642#issuecomment-888852075
I have a little question. why all tsfile time are less than System.currentTimeMillis()?
if tsfile time are better than System.currentTimeMillis(), Does iotdb-server used?
The time of real data may change due to a fault in the collection device (data is later than the current time). In this case, the entire cluster cannot be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #3642: [IOTDB-1531] Check tsfile creation time when recovering
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #3642:
URL: https://github.com/apache/iotdb/pull/3642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HeimingZ commented on pull request #3642: [IOTDB-1531] Check tsfile time when recovering
Posted by GitBox <gi...@apache.org>.
HeimingZ commented on pull request #3642:
URL: https://github.com/apache/iotdb/pull/3642#issuecomment-890641591
> I have a little question. why all tsfile time are less than System.currentTimeMillis()?
> if tsfile time are better than System.currentTimeMillis(), Does iotdb-server used?
> The time of real data may change due to a fault in the collection device (data is later than the current time). In this case, the entire cluster cannot be used.
<img width="1043" alt="tsfile name time" src="https://user-images.githubusercontent.com/43991780/127791993-5de55101-fed8-4c3c-a39a-b1ea8f5f4778.png">
This pr aims to make sure server time zone is correct and all tsfiles' created time is less than system current time. It only compares the created time of tsfile, which is determined by the server, so data from devices won't affect the use of iotdb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org