You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/09/10 18:46:44 UTC
Review Request 38261: Empty properties in ams-site
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38261/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
Bugs: AMBARI-13061
https://issues.apache.org/jira/browse/AMBARI-13061
Repository: ambari
Description
-------
java.lang.IllegalStateException: There are tabs with error counter present! Tabs with errors: AMBARI_METRICS
Dev deploy fails because validation fails for empty properties:
timeline.metrics.cluster.aggregate.splitpoints
timeline.metrics.host.aggregate.splitpoints
Diffs
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 7dfd8a7
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 95d94a5
Diff: https://reviews.apache.org/r/38261/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 38261: Empty properties in ams-site
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38261/#review98423
-----------------------------------------------------------
Ship it!
No need for another review, go ahead with commit after change.
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java (line 340)
<https://reviews.apache.org/r/38261/#comment154899>
StringUtils already checks for null, no need for first check.
- Sid Wagle
On Sept. 10, 2015, 4:46 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38261/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 4:46 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13061
> https://issues.apache.org/jira/browse/AMBARI-13061
>
>
> Repository: ambari
>
>
> Description
> -------
>
> java.lang.IllegalStateException: There are tabs with error counter present! Tabs with errors: AMBARI_METRICS
> Dev deploy fails because validation fails for empty properties:
> timeline.metrics.cluster.aggregate.splitpoints
> timeline.metrics.host.aggregate.splitpoints
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 7dfd8a7
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 95d94a5
>
> Diff: https://reviews.apache.org/r/38261/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>