[GitHub] [spark] pan3793 commented on a diff in pull request #40307: [SPARK-42689][CORE][SHUFFLE]: Allow ShuffleDriverComponent to declare if shuffle data is reliably stored

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #40307:
URL: https://github.com/apache/spark/pull/40307#discussion_r1129779862


##########
core/src/main/java/org/apache/spark/shuffle/api/ShuffleDriverComponents.java:
##########
@@ -61,4 +61,13 @@ default void registerShuffle(int shuffleId) {}
    * @param blocking Whether this call should block on the deletion of the data.
    */
   default void removeShuffle(int shuffleId, boolean blocking) {}
+
+  /**
+   * Does this shuffle component support reliable storage - external to the lifecycle of the
+   * executor host ? For example, writing shuffle data to a distributed filesystem or
+   * persisting it in a remote shuffle service.
+   */
+  default boolean supportsReliableStorage() {

Review Comment:
   nit: maybe "supports" => "support"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org