[GitHub] cbickel commented on a change in pull request #2735: Remove redundant view which predates db split into activations and assets.

[gi...@git.apache.org]

cbickel commented on a change in pull request #2735: Remove redundant view which predates db split into activations and assets.
URL: https://github.com/apache/incubator-openwhisk/pull/2735#discussion_r139883266
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala
 ##########
 @@ -119,4 +124,28 @@ object WhiskActivation
   // Caching activations doesn't make much sense in the common case as usually,
   // an activation is only asked for once.
   override val cacheEnabled = false
+
+  /**
+   * Queries datastore for activation records which have an entity name matching the
+   * given parameter.
+   *
+   * @return list of records as JSON object if docs parameter is false, as Left
+   *         and a list of the WhiskActivations if including the full record, as Right
+   */
+  def listActivationsMatchingName(db: ArtifactStore[WhiskActivation],
+                                  namespace: EntityPath,
+                                  name: EntityName,
+                                  skip: Int,
+                                  limit: Int,
+                                  docs: Boolean = false,
 
 Review comment:
   What do think about renaming this to `includeDocs`.
   Then it would be consistent with `listCollectionInNamespace`.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services