You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Brock Noland (Code Review)" <ge...@cloudera.org> on 2016/09/23 02:05:14 UTC

[kudu-CR] [WIP][java] KUDU-1563. Add support for INSERT IGNORE 

Brock Noland has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4523

Change subject: [WIP][java] KUDU-1563. Add support for INSERT IGNORE
......................................................................

[WIP][java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

TODO - more tests

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 84 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4523

to look at the new patch set (#8).

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 131 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/8
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/4523

to look at the new patch set (#16).

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 136 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/16
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-Change-Number: 4523
Gerrit-PatchSet: 16
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4523

to look at the new patch set (#14).

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 138 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/14
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 14
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [WIP][java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Brock Noland has uploaded a new patch set (#2).

Change subject: [WIP][java] KUDU-1563. Add support for INSERT IGNORE
......................................................................

[WIP][java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

TODO - more tests

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 86 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has uploaded a new patch set (#24) to the change originally created by Brock Noland. ( http://gerrit.cloudera.org:8080/4523 )

Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT_IGNORE

Implements java support for the `INSERT_IGNORE' operation.

I manually tested this against an old server version without the INSERT_IGNORE operation  suport and it returns the correct
error with a message that says: “Unknown operation type: 10”.

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 125 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/24
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-Change-Number: 4523
Gerrit-PatchSet: 24
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4523

to look at the new patch set (#10).

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 141 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/10
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4523 )

Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE
......................................................................


Patch Set 25: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-Change-Number: 4523
Gerrit-PatchSet: 25
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 Feb 2020 20:51:32 +0000
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/4523 )

Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT_IGNORE

Implements java support for the `INSERT_IGNORE' operation.

I manually tested this against an old server version without
INSERT_IGNORE operation support and it returns the correct
error with a message that says: “Unknown operation type: 10”.

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Reviewed-on: http://gerrit.cloudera.org:8080/4523
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 126 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-Change-Number: 4523
Gerrit-PatchSet: 27
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4523 )

Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE
......................................................................


Patch Set 25:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4523/25//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/4523/25//COMMIT_MSG@11
PS25, Line 11: I manually tested this against an old server version without the INSERT_IGNORE operation  suport and it returns the correct
> Too long. Also 'support', and I think there are two spaces in a row between
Done


http://gerrit.cloudera.org:8080/#/c/4523/25/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java:

http://gerrit.cloudera.org:8080/#/c/4523/25/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@171
PS25, Line 171: maybe
> may be
Done


http://gerrit.cloudera.org:8080/#/c/4523/25/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@170
PS25, Line 170: An insert ignore, ignores
              :    * duplicate row errors
> How about "An insert ignore will ignore duplicate row errors".
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-Change-Number: 4523
Gerrit-PatchSet: 25
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Feb 2020 16:03:27 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................


Patch Set 7:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4523/7/java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
File java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java:

Line 18: 
nit: extra line


http://gerrit.cloudera.org:8080/#/c/4523/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java:

PS7, Line 140: insert ignore
I think this could be documented better, like how exactly is this "ignore" behavior taking place?


http://gerrit.cloudera.org:8080/#/c/4523/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java:

PS7, Line 225: final
nit: doesn't need to be final.


PS7, Line 227: t
nit: end code comments with periods.


PS7, Line 237: r
same


Line 244:   }
Could be interesting in the clients to test mixing different types of operations with InsertIgnore to make sure we report the errors correctly.


-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Brock Noland has posted comments on this change.

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................


Patch Set 7:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4523/7/java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
File java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java:

Line 18: 
> nit: extra line
Done


http://gerrit.cloudera.org:8080/#/c/4523/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java:

PS7, Line 140: insert ignore
> I think this could be documented better, like how exactly is this "ignore" 
Done


http://gerrit.cloudera.org:8080/#/c/4523/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java:

PS7, Line 225: final
> nit: doesn't need to be final.
Done


PS7, Line 227: t
> nit: end code comments with periods.
Done


PS7, Line 237: r
> same
Done


Line 244:   }
> Could be interesting in the clients to test mixing different types of opera
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4523 )

Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE
......................................................................


Patch Set 26: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-Change-Number: 4523
Gerrit-PatchSet: 26
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Feb 2020 20:46:57 +0000
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has uploaded a new patch set (#26) to the change originally created by Brock Noland. ( http://gerrit.cloudera.org:8080/4523 )

Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT_IGNORE

Implements java support for the `INSERT_IGNORE' operation.

I manually tested this against an old server version without
INSERT_IGNORE operation support and it returns the correct
error with a message that says: “Unknown operation type: 10”.

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 126 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/26
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-Change-Number: 4523
Gerrit-PatchSet: 26
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has uploaded a new patch set (#25) to the change originally created by Brock Noland. ( http://gerrit.cloudera.org:8080/4523 )

Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT_IGNORE

Implements java support for the `INSERT_IGNORE' operation.

I manually tested this against an old server version without the INSERT_IGNORE operation  suport and it returns the correct
error with a message that says: “Unknown operation type: 10”.

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 126 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/25
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-Change-Number: 4523
Gerrit-PatchSet: 25
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4523 )

Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE
......................................................................


Patch Set 25:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4523/25//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/4523/25//COMMIT_MSG@11
PS25, Line 11: I manually tested this against an old server version without the INSERT_IGNORE operation  suport and it returns the correct
Too long. Also 'support', and I think there are two spaces in a row between 'operation' and 'support'.


http://gerrit.cloudera.org:8080/#/c/4523/25/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java:

http://gerrit.cloudera.org:8080/#/c/4523/25/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@171
PS25, Line 171: maybe
may be


http://gerrit.cloudera.org:8080/#/c/4523/25/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@170
PS25, Line 170: An insert ignore, ignores
              :    * duplicate row errors
How about "An insert ignore will ignore duplicate row errors".



-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-Change-Number: 4523
Gerrit-PatchSet: 25
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Feb 2020 02:19:47 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4523

to look at the new patch set (#5).

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 87 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Brock Noland has posted comments on this change.

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................


Patch Set 9:

I need to update the java client to send required features.

-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4523

to look at the new patch set (#15).

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 139 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/15
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 15
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [WIP][java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4523

to look at the new patch set (#3).

Change subject: [WIP][java] KUDU-1563. Add support for INSERT IGNORE
......................................................................

[WIP][java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

TODO - more tests

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 87 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4523

to look at the new patch set (#11).

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................

[java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 139 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/11
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-Change-Number: 4523
Gerrit-PatchSet: 25
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................


Patch Set 8: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No