You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by PhantomYdn <gi...@git.apache.org> on 2014/06/22 08:49:33 UTC

[GitHub] wicket pull request: Support of getting and setting properties cus...

GitHub user PhantomYdn opened a pull request:

    https://github.com/apache/wicket/pull/74

    Support of getting and setting properties customly in PropertyResolver

    There is no way to customize getting of properties from the object. All possible ways to gain properties are hardcoded in PropertyResolver. 
    But, for example, there is set of NoSQL document DBs which have some class "Document" to work with DB. And to get some property of that document you should call something like this: 'doc.getProperty("myPropertyName")'.
    
    This pull request enables possibility to specify custom GetAndSet for your type of object. Please take a look to PropertyResolverTest

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PhantomYdn/wicket custom-properties

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
    
----
commit 72073ee2cffcff4664792621540f3c08ad77aa9e
Author: Ilia Naryzhny <ph...@ydn.ru>
Date:   2014-06-20T16:04:03Z

    Non working draft of custom properties support in PropertyResolver

commit 5443eb2ddd16ecf03af0b8cd35490d35679942d8
Author: Ilia Naryzhny <ph...@ydn.ru>
Date:   2014-06-22T06:44:23Z

    Support of custom GetAndSeters for PropertyResolver
    Test custom GetAndSetters for PropertyResolver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #74: Support of getting and setting properties customly in Prop...

Posted by PhantomYdn <gi...@git.apache.org>.
Github user PhantomYdn commented on the issue:

    https://github.com/apache/wicket/pull/74
  
    Looks interesting and promising:)
    Could you please also fix silly current wicket issue with that stuff which currently exist?
    Issue is that if there is only a setter and no getter: PropertyResolver will fail.
    
    And what's target release? I hope that some 7.XX?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #74: Support of getting and setting properties customly in Prop...

Posted by svenmeier <gi...@git.apache.org>.
Github user svenmeier commented on the issue:

    https://github.com/apache/wicket/pull/74
  
    I'm working on a different solution, please take a look at https://github.com/apache/wicket/tree/WICKET-5623-extensible-propertyresolver


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request #74: Support of getting and setting properties customly ...

Posted by PhantomYdn <gi...@git.apache.org>.
Github user PhantomYdn closed the pull request at:

    https://github.com/apache/wicket/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #74: Support of getting and setting properties customly in Prop...

Posted by PhantomYdn <gi...@git.apache.org>.
Github user PhantomYdn commented on the issue:

    https://github.com/apache/wicket/pull/74
  
    Created: https://issues.apache.org/jira/browse/WICKET-6201
    
    Also - it will be very helfull to make getObjectWithGetAndSet public. Sometimes it's usefully to introspect object by wicket utilities. We switched in [Orienteer](http://orienteer.org) from spring bean introspection to wicket due not accurate working with beans in Spring (for example if there is a class with methods like: public String getValue(); public void setValue(Object value) - Spring is failing measurably even if property "value" was not directly requested).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #74: Support of getting and setting properties customly in Prop...

Posted by svenmeier <gi...@git.apache.org>.
Github user svenmeier commented on the issue:

    https://github.com/apache/wicket/pull/74
  
    > if there is only a setter and no getter, PropertyResolver will fail.
    
    Please open a separate issue for that.
    
    I'm planning this change for 6.x, 7.x and 8.x


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: Support of getting and setting properties cus...

Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the pull request:

    https://github.com/apache/wicket/pull/74#issuecomment-73840792
  
    It would be nice if you could file in a ticket in JIRA so that it can be catched up by the Wicket Dev's. For more information take a look here: https://cwiki.apache.org/confluence/display/WICKET/Contributing+to+Wicket


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #74: Support of getting and setting properties customly in Prop...

Posted by PhantomYdn <gi...@git.apache.org>.
Github user PhantomYdn commented on the issue:

    https://github.com/apache/wicket/pull/74
  
    Thanks for implementation of this feature!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: Support of getting and setting properties cus...

Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:

    https://github.com/apache/wicket/pull/74#issuecomment-73844439
  
    https://issues.apache.org/jira/browse/WICKET-5623


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #74: Support of getting and setting properties customly in Prop...

Posted by svenmeier <gi...@git.apache.org>.
Github user svenmeier commented on the issue:

    https://github.com/apache/wicket/pull/74
  
    Please close this pull request: WICKET-5623 adds IPropertyLocator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---