You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/07/01 07:21:32 UTC

Review Request 36077: Renamed low level scheduler libprocess test to event call framework test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36077/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Jie Yu, and Marco Massenzio.


Repository: mesos


Description
-------

Also deleted the low level scheduler pthread test because it doesn't give us any new insights AFAICT but always needed to be updated for API changes.


Diffs
-----

  src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 
  src/examples/low_level_scheduler_libprocess.cpp 63e42bc83ccc0e4085d7619c478e5b010a49098a 
  src/examples/low_level_scheduler_pthread.cpp 7630d417620490b043b04d243cc32c05f9aa3f6a 
  src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca 
  src/tests/low_level_scheduler_libprocess_test.sh 7984559e8ad7e0c1b0dda2355f06b4fc9da5103e 
  src/tests/low_level_scheduler_pthread_test.sh c6e7115f2db635e352fb2122e0cb9f6af2613760 

Diff: https://reviews.apache.org/r/36077/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 36077: Renamed low level scheduler libprocess test to event call framework test.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36077/#review90075
-----------------------------------------------------------

Ship it!


Alternatively, now that we're mostly calling this the HTTP API, we could call this the "http" scheduler / framework.

- Ben Mahler


On July 1, 2015, 5:21 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36077/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 5:21 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Marco Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also deleted the low level scheduler pthread test because it doesn't give us any new insights AFAICT but always needed to be updated for API changes.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 
>   src/examples/low_level_scheduler_libprocess.cpp 63e42bc83ccc0e4085d7619c478e5b010a49098a 
>   src/examples/low_level_scheduler_pthread.cpp 7630d417620490b043b04d243cc32c05f9aa3f6a 
>   src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca 
>   src/tests/low_level_scheduler_libprocess_test.sh 7984559e8ad7e0c1b0dda2355f06b4fc9da5103e 
>   src/tests/low_level_scheduler_pthread_test.sh c6e7115f2db635e352fb2122e0cb9f6af2613760 
> 
> Diff: https://reviews.apache.org/r/36077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>