You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/25 12:16:01 UTC
[GitHub] [incubator-hudi] listenLearning opened a new pull request #1135:
[HUDI-233]Redo log statements using SLF4J
listenLearning opened a new pull request #1135: [HUDI-233]Redo log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1135
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on issue #1135: [HUDI-233]Redo log
statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on issue #1135: [HUDI-233]Redo log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1135#issuecomment-568937528
Thanks for opening the PR @listenLearning . Here are my some thoughts.
- we must ensure the log4j paly well with spark/hive/presto to avoid version conflicts, more context [here](https://issues.apache.org/jira/projects/HUDI/issues/HUDI-233?filter=allopenissues).
- so please verify it in your own cluster to ensure the modification is correct.
- only replace the `LogManager.getLogger` with `LogFactory.getLogger` is incompleted, you need replace the `LOG.info,LOG.error,LOG.debug` statement in the project also.
- IMHO, I would like to suggest redo log statements module by module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] listenLearning commented on issue #1135:
[HUDI-233]Redo log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
listenLearning commented on issue #1135: [HUDI-233]Redo log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1135#issuecomment-568947384
copy that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1135:
[HUDI-233]Redo log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1135: [HUDI-233]Redo log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1135#issuecomment-568940452
> @leesf @lamber-ken who were looking into this before..
> @leesf could you shepherd this one? My concerns are mostly around all bundles working smoothly.
>
> IIUC this PR is low touch.. Just adds log4j facade and changes code.. We need to verify logs do show up on all of Hive, presto, spark logs by running through the demo steps..
I thinks @leesf's advice is reasonable, redo log statements module by module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] listenLearning closed pull request #1135:
[HUDI-233]Redo log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
listenLearning closed pull request #1135: [HUDI-233]Redo log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on issue #1135: [HUDI-233]Redo log
statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on issue #1135: [HUDI-233]Redo log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1135#issuecomment-568946135
> @leesf @lamber-ken who were looking into this before..
> @leesf could you shepherd this one? My concerns are mostly around all bundles working smoothly.
>
> IIUC this PR is low touch.. Just adds log4j facade and changes code.. We need to verify logs do show up on all of Hive, presto, spark logs by running through the demo steps..
Yes, the redo work should be verified carefully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services