You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2020/01/11 21:20:31 UTC
[spark] branch branch-2.4 updated: [SPARK-30312][SQL][FOLLOWUP] Use
inequality check instead to be robust
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new d84a96c [SPARK-30312][SQL][FOLLOWUP] Use inequality check instead to be robust
d84a96c is described below
commit d84a96cde8fb024b2c300ae08f81d36783361a3b
Author: Liang-Chi Hsieh <vi...@gmail.com>
AuthorDate: Sat Jan 11 13:19:04 2020 -0800
[SPARK-30312][SQL][FOLLOWUP] Use inequality check instead to be robust
### What changes were proposed in this pull request?
This is a followup to fix a brittle assert in a test case.
### Why are the changes needed?
Original assert assumes that default permission is `rwxr-xr-x`, but in jenkins [env](https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7-hive-1.2/6/testReport/junit/org.apache.spark.sql.execution.command/InMemoryCatalogedDDLSuite/SPARK_30312__truncate_table___keep_acl_permission/) it could be `rwxrwxr-x`.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Unit test.
Closes #27175 from viirya/hot-fix.
Authored-by: Liang-Chi Hsieh <vi...@gmail.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
(cherry picked from commit b04407169b8165fe634c9c2214c0f54e45642fa6)
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
.../test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
index 753fe1c..790f6fc 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
@@ -1974,7 +1974,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
val fileStatus2 = fs.getFileStatus(tablePath)
if (ignore) {
- assert(fileStatus2.getPermission().toString() == "rwxr-xr-x")
+ assert(fileStatus2.getPermission().toString() != "rwxrwxrwx")
} else {
assert(fileStatus2.getPermission().toString() == "rwxrwxrwx")
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org