You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2015/02/27 01:15:01 UTC
Review Request 31510: Patch for kafka-1400
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31510/
-----------------------------------------------------------
Review request for kafka.
Bugs: kafka-1400
https://issues.apache.org/jira/browse/kafka-1400
Repository: kafka
Description
-------
kafka-1400; send a large chunk of bytes to trigger a socket flush
Diffs
-----
core/src/test/scala/unit/kafka/network/SocketServerTest.scala 78b431f9c88cca1bc5e430ffd41083d0e92b7e75
Diff: https://reviews.apache.org/r/31510/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 31510: Patch for kafka-1400
Posted by Ewen Cheslack-Postava <me...@ewencp.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31510/#review74411
-----------------------------------------------------------
Ship it!
LGTM. Tested 50 times with no failures.
- Ewen Cheslack-Postava
On Feb. 27, 2015, 12:15 a.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31510/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 12:15 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1400
> https://issues.apache.org/jira/browse/kafka-1400
>
>
> Repository: kafka
>
>
> Description
> -------
>
> kafka-1400; send a large chunk of bytes to trigger a socket flush
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/network/SocketServerTest.scala 78b431f9c88cca1bc5e430ffd41083d0e92b7e75
>
> Diff: https://reviews.apache.org/r/31510/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 31510: Patch for kafka-1400
Posted by Jiangjie Qin <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31510/#review74415
-----------------------------------------------------------
Ship it!
Ship It!
- Jiangjie Qin
On Feb. 27, 2015, 12:15 a.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31510/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 12:15 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1400
> https://issues.apache.org/jira/browse/kafka-1400
>
>
> Repository: kafka
>
>
> Description
> -------
>
> kafka-1400; send a large chunk of bytes to trigger a socket flush
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/network/SocketServerTest.scala 78b431f9c88cca1bc5e430ffd41083d0e92b7e75
>
> Diff: https://reviews.apache.org/r/31510/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>