You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/15 17:35:25 UTC

[GitHub] [superset] codecov-io edited a comment on pull request #12552: fix(explore): deprecated x periods pattern in new time picker value

codecov-io edited a comment on pull request #12552:
URL: https://github.com/apache/superset/pull/12552#issuecomment-761077081


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12552?src=pr&el=h1) Report
   > Merging [#12552](https://codecov.io/gh/apache/superset/pull/12552?src=pr&el=desc) (8a2e6f4) into [master](https://codecov.io/gh/apache/superset/commit/e6a76a58d35261efccd1fba8ce05177c13a49020?el=desc) (e6a76a5) will **increase** coverage by `4.06%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12552?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12552      +/-   ##
   ==========================================
   + Coverage   66.73%   70.79%   +4.06%     
   ==========================================
     Files        1015      529     -486     
     Lines       49625    19668   -29957     
     Branches     4839     4840       +1     
   ==========================================
   - Hits        33116    13924   -19192     
   + Misses      16386     5617   -10769     
   - Partials      123      127       +4     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.62% <100.00%> (-0.37%)` | :arrow_down: |
   | javascript | `60.73% <0.00%> (-0.01%)` | :arrow_down: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12552?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...s/controls/DateFilterControl/DateFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC50c3g=) | `85.58% <100.00%> (+0.13%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.58% <0.00%> (-5.07%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.11% <0.00%> (-3.85%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `38.42% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | | |
   | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | | |
   | [...alter\_sql\_column\_data\_type\_in\_query\_mysql\_table.py](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZmM2OTI3NGMyNWFfYWx0ZXJfc3FsX2NvbHVtbl9kYXRhX3R5cGVfaW5fcXVlcnlfbXlzcWxfdGFibGUucHk=) | | |
   | [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | | |
   | ... and [482 more](https://codecov.io/gh/apache/superset/pull/12552/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12552?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12552?src=pr&el=footer). Last update [e6a76a5...a63f7ee](https://codecov.io/gh/apache/superset/pull/12552?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org