You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by sm...@apache.org on 2018/08/03 17:54:52 UTC

directory-fortress-core git commit: + a couple of todos

Repository: directory-fortress-core
Updated Branches:
  refs/heads/master 25c4c97c9 -> aa0542732


+ a couple of todos


Project: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/commit/aa054273
Tree: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/tree/aa054273
Diff: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/diff/aa054273

Branch: refs/heads/master
Commit: aa0542732d669d0d514a462315ec4dacd51007f2
Parents: 25c4c97
Author: Shawn McKinney <sm...@apache.org>
Authored: Wed Aug 1 06:56:19 2018 -0500
Committer: Shawn McKinney <sm...@apache.org>
Committed: Wed Aug 1 06:56:19 2018 -0500

----------------------------------------------------------------------
 .../java/org/apache/directory/fortress/core/impl/OrgUnitDAO.java    | 1 +
 src/main/java/org/apache/directory/fortress/core/impl/UserP.java    | 1 +
 2 files changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/aa054273/src/main/java/org/apache/directory/fortress/core/impl/OrgUnitDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/OrgUnitDAO.java b/src/main/java/org/apache/directory/fortress/core/impl/OrgUnitDAO.java
index bf3a265..4c82ce5 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/OrgUnitDAO.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/OrgUnitDAO.java
@@ -719,6 +719,7 @@ final class OrgUnitDAO extends LdapDataProvider
         entity.setDescription( getAttribute( le, SchemaConstants.DESCRIPTION_AT ) );
         String dn = le.getDn().getName();
 
+        // TODO: the dn.contains is case sensitive which needs to be fixed:
         if ( dn.contains( getRootDn( contextId, GlobalIds.PSU_ROOT ) ) )
         {
             entity.setType( OrgUnit.Type.PERM );

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/aa054273/src/main/java/org/apache/directory/fortress/core/impl/UserP.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/UserP.java b/src/main/java/org/apache/directory/fortress/core/impl/UserP.java
index 99c96a3..f5cc625 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/UserP.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/UserP.java
@@ -513,6 +513,7 @@ final class UserP
             }
         }
         // Did the caller pass in a set of dynamic constraints as properties?
+        // TODO: Guard with a property? i.e. user.session.props.enabled
         if ( user.getProps() != null )
         {
             session.getUser().addProperties( user.getProperties() );